You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/06/16 15:19:33 UTC
[GitHub] [incubator-gobblin] arjun4084346 opened a new pull request #3044: [GOBBLIN-1198] use DatasetCleanerTask to clean job status
arjun4084346 opened a new pull request #3044:
URL: https://github.com/apache/incubator-gobblin/pull/3044
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1198
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
use DatasetCleanerTask to clean job status, because the old way, using StateStoreCleanerRunnable, is deprecated
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
trivial changes
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] codecov-commenter commented on pull request #3044: [GOBBLIN-1198] use DatasetCleanerTask to clean job status
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #3044:
URL: https://github.com/apache/incubator-gobblin/pull/3044#issuecomment-644901118
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=h1) Report
> Merging [#3044](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/93ee79546759d73310fb6f949fcbfc57e232ccd8&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #3044 +/- ##
============================================
+ Coverage 45.78% 45.79% +0.01%
- Complexity 9328 9336 +8
============================================
Files 1956 1957 +1
Lines 74423 74439 +16
Branches 8250 8252 +2
============================================
+ Hits 34073 34089 +16
- Misses 37157 37159 +2
+ Partials 3193 3191 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...n/java/org/apache/gobblin/configuration/State.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9TdGF0ZS5qYXZh) | `28.26% <ø> (ø)` | `18.00 <0.00> (ø)` | |
| [...blin/metastore/util/StateStoreCleanerRunnable.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRhc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0YXN0b3JlL3V0aWwvU3RhdGVTdG9yZUNsZWFuZXJSdW5uYWJsZS5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==) | `44.87% <0.00%> (-3.08%)` | `10.00 <0.00> (ø)` | |
| [...in/java/org/apache/gobblin/cluster/SingleTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlVGFzay5qYXZh) | `80.28% <0.00%> (-2.08%)` | `12.00% <0.00%> (ø%)` | |
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `62.79% <0.00%> (-1.50%)` | `6.00% <0.00%> (ø%)` | |
| [...ache/gobblin/cluster/SingleFailInCreationTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvU2luZ2xlRmFpbEluQ3JlYXRpb25UYXNrLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ctor/extract/kafka/KafkaExtractorStatsTracker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9leHRyYWN0b3IvZXh0cmFjdC9rYWZrYS9LYWZrYUV4dHJhY3RvclN0YXRzVHJhY2tlci5qYXZh) | `87.01% <0.00%> (+1.48%)` | `50.00% <0.00%> (+5.00%)` | |
| [...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=) | `49.51% <0.00%> (+1.94%)` | `12.00% <0.00%> (ø%)` | |
| [...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/3044/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh) | `40.47% <0.00%> (+5.55%)` | `16.00% <0.00%> (+2.00%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=footer). Last update [93ee795...6f8a0b5](https://codecov.io/gh/apache/incubator-gobblin/pull/3044?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-gobblin] asfgit closed pull request #3044: [GOBBLIN-1198] use DatasetCleanerTask to clean job status
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3044:
URL: https://github.com/apache/incubator-gobblin/pull/3044
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org