[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #874: Add button to enable/disable storage pool

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #874:
URL: https://github.com/apache/cloudstack-primate/pull/874#discussion_r533099526



##########
File path: src/config/section/infra/primaryStorages.js
##########
@@ -63,6 +63,24 @@ export default {
       dataView: true,
       args: ['name', 'tags', 'capacitybytes', 'capacityiops']
     },
+    {
+      api: 'updateStoragePool',
+      icon: 'pause-circle',
+      label: 'label.disable.storage',
+      message: 'message.confirm.disable.storage',
+      dataView: true,
+      defaultArgs: { enabled: false },
+      show: (record) => { return ['Up', 'Connecting', 'Down', 'ErrorInMaintenance'].includes(record.state) }

Review comment:
       @GabrielBrascher Does the backend allow disabling a pool if its state is not `Up` ?
   https://github.com/apache/cloudstack/blob/master/server/src/main/java/com/cloud/storage/StorageManagerImpl.java#L782




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org