You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "coryan (via GitHub)" <gi...@apache.org> on 2023/06/16 12:44:37 UTC

[GitHub] [arrow] coryan commented on pull request #36119: GH-35879: [C++] Bump bundled google-cloud-cpp to 2.12.0

coryan commented on PR #36119:
URL: https://github.com/apache/arrow/pull/36119#issuecomment-1594619882

   We need to update the tests. The client library now performs more validation, and the testbench is too forgiving.  The test used to get away with a request that would have failed against production.
   
   We need to set the  GOOGLE_CLOUD_PROJECT environment variable to some value good for testing.  Alternatively, we need to expand the GCSFS configuration to accept the project id as one of the (optional) parameters and use that in the test.
   
   Should I send a separate PR or should we try to add these changes to this PR?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org