You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/05 16:27:29 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #10903: [Hexagon] Use single allocation to back 2-d arrays
Lunderberg opened a new pull request, #10903:
URL: https://github.com/apache/tvm/pull/10903
Currently, each allocation allocates an entire page, so even a relatively small number of allocations can use very large amounts of VTCM. This commit changes calls to `AllocVtcmWorkspace` of shape `[N,M]` from performing `N` allocations of size `M`, to 1 allocation of size `N*M`. Since `N` is usually much smaller than a page, this reduces the total amount of memory required.
This is an intermediate step, where the long-term solution is to use static planning for VTCM allocations. This returns the same `void**` type as the static planning eventually will, but avoids excess memory use in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10903: [Hexagon] Use single allocation to back 2-d arrays
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10903:
URL: https://github.com/apache/tvm/pull/10903#issuecomment-1088983395
To maintain alignment of each individual region, padding may be added to the single allocation. As a result, this PR is dependent on functionality introduced in https://github.com/apache/tvm/pull/10878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] csullivan merged pull request #10903: [Hexagon] Use single allocation to back 2-d arrays
Posted by GitBox <gi...@apache.org>.
csullivan merged PR #10903:
URL: https://github.com/apache/tvm/pull/10903
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10903: [Hexagon] Use single allocation to back 2-d arrays
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10903:
URL: https://github.com/apache/tvm/pull/10903#issuecomment-1089348526
Rebased onto main to restart CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] Lunderberg commented on pull request #10903: [Hexagon] Use single allocation to back 2-d arrays
Posted by GitBox <gi...@apache.org>.
Lunderberg commented on PR #10903:
URL: https://github.com/apache/tvm/pull/10903#issuecomment-1089027592
Current CI failures are the expected differences at the C++ side, which are resolved in #10878. No changes expected to be needed for them, but will need to relaunch CI once it lands.
```
[2022-04-05T16:42:41.580Z] 196 - HexagonBuffer.nd_copy_from (Failed)
[2022-04-05T16:42:41.580Z] 198 - HexagonBuffer.2d_copy_from_1d (Failed)
[2022-04-05T16:42:41.580Z] 199 - HexagonBuffer.1d_copy_from_2d (Failed)
[2022-04-05T16:42:41.580Z] 201 - HexagonBuffer.nd_copy_from_nd_smaller_size (Failed)
[2022-04-05T16:42:41.580Z] 202 - HexagonBuffer.md_copy_from_nd (Failed)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org