You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by GitBox <gi...@apache.org> on 2019/05/28 17:48:25 UTC
[GitHub] [madlib] kaknikhil commented on a change in pull request #397: DL:
Update content of the model summary table
kaknikhil commented on a change in pull request #397: DL: Update content of the model summary table
URL: https://github.com/apache/madlib/pull/397#discussion_r287543408
##########
File path: src/ports/postgres/modules/deep_learning/madlib_keras.py_in
##########
@@ -54,27 +55,7 @@ from utilities.validate_args import get_col_value_and_type
from utilities.validate_args import get_expr_type
from utilities.validate_args import quote_ident
-def get_source_summary_table_dict(fit_validator):
- source_summary = plpy.execute("""
- SELECT
- {class_values} AS class_values,
- {norm_const} AS norm_const,
- {dep_vartype} AS dep_vartype,
- {dep_varname} AS dependent_varname_in_source_table,
- {indep_varname} AS independent_varname_in_source_table
- FROM {tbl}
- """.format(class_values=CLASS_VALUES_COLNAME,
- norm_const=NORMALIZING_CONST_COLNAME,
- dep_vartype=DEPENDENT_VARTYPE_COLNAME,
- dep_varname='dependent_varname',
- indep_varname='independent_varname',
- tbl=fit_validator.source_summary_table))[0]
- source_summary['class_values_type'] = get_expr_type(
- CLASS_VALUES_COLNAME, fit_validator.source_summary_table)
- source_summary['norm_const_type'] = get_expr_type(
- NORMALIZING_CONST_COLNAME, fit_validator.source_summary_table)
- return source_summary
-
+@MinWarning("error")
Review comment:
the log level should be warning instead of error because we have a plpy.warning statement in our code. same applies to all the other minwarnings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services