You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by jr...@apache.org on 2017/08/29 16:22:48 UTC
[trafficserver] branch master updated (fa7190b -> 103ef38)
This is an automated email from the ASF dual-hosted git repository.
jrushford pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.
from fa7190b Add 'BufferWriter' class for constructing strings/sequences of characters.
new 2aed3f6 Fix coverity issues 1379739 - 1379741
new 103ef38 Fix coverity issues 1379739
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
iocore/utils/Machine.cc | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
--
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].
[trafficserver] 01/02: Fix coverity issues 1379739 - 1379741
Posted by jr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jrushford pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 2aed3f66d284b97c33fb35c83aad7b0b1d6e1a90
Author: John J. Rushford <jr...@apache.org>
AuthorDate: Mon Aug 21 15:57:08 2017 +0000
Fix coverity issues 1379739 - 1379741
---
iocore/utils/Machine.cc | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/iocore/utils/Machine.cc b/iocore/utils/Machine.cc
index d6d70e4..c2c24fd 100644
--- a/iocore/utils/Machine.cc
+++ b/iocore/utils/Machine.cc
@@ -295,12 +295,10 @@ Machine::insert_id(char *id)
char *value = nullptr;
size_t len = strlen(id);
- if (id != nullptr) {
- value = static_cast<char *>(ats_malloc(len));
- make_to_lower_case(id, lower_case_name, sizeof(lower_case_name));
- strncpy(value, lower_case_name, strlen(lower_case_name));
- ink_hash_table_insert(machine_id_strings, lower_case_name, value);
- }
+ value = static_cast<char *>(ats_malloc(len + 1));
+ make_to_lower_case(id, lower_case_name, sizeof(lower_case_name));
+ strncpy(value, lower_case_name, strlen(lower_case_name));
+ ink_hash_table_insert(machine_id_strings, lower_case_name, value);
}
void
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.
[trafficserver] 02/02: Fix coverity issues 1379739
Posted by jr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
jrushford pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git
commit 103ef3872a32aa7779a7bd8046682177c425861d
Author: jrushf1239k <Jo...@cable.comcast.com>
AuthorDate: Tue Aug 22 16:05:58 2017 +0000
Fix coverity issues 1379739
---
iocore/utils/Machine.cc | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/iocore/utils/Machine.cc b/iocore/utils/Machine.cc
index c2c24fd..82e71cb 100644
--- a/iocore/utils/Machine.cc
+++ b/iocore/utils/Machine.cc
@@ -293,21 +293,19 @@ Machine::insert_id(char *id)
{
char lower_case_name[TS_MAX_HOST_NAME_LEN + 1] = {0};
char *value = nullptr;
- size_t len = strlen(id);
- value = static_cast<char *>(ats_malloc(len + 1));
make_to_lower_case(id, lower_case_name, sizeof(lower_case_name));
- strncpy(value, lower_case_name, strlen(lower_case_name));
+ value = ats_strndup(lower_case_name, strlen(lower_case_name));
ink_hash_table_insert(machine_id_strings, lower_case_name, value);
}
void
Machine::insert_id(IpAddr *ipaddr)
{
- int length = INET6_ADDRSTRLEN + 1;
- char *string_value = static_cast<char *>(ats_calloc(length, 1));
+ int length = INET6_ADDRSTRLEN + 1;
if (ipaddr != nullptr) {
+ char *string_value = static_cast<char *>(ats_calloc(length, 1));
ipaddr->toString(string_value, length);
ink_hash_table_insert(machine_id_strings, string_value, string_value);
ink_hash_table_insert(machine_id_ipaddrs, string_value, ipaddr);
--
To stop receiving notification emails like this one, please contact
"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>.