[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5249: Disallow SORT BY in SQL

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #5249:
URL: https://github.com/apache/arrow-datafusion/pull/5249#discussion_r1103622817


##########
datafusion/sql/src/select.rs:
##########
@@ -59,6 +59,9 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
         if select.top.is_some() {
             return Err(DataFusionError::NotImplemented("TOP".to_string()));
         }
+        if !select.sort_by.is_empty() {

Review Comment:
   👍 
   
   It would be nice to add a .slt test for this case, but I also think it is ok not to



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org