You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/11/05 15:53:58 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #6333: Fix nil panic from using var when err exists

rob05c opened a new pull request #6333:
URL: https://github.com/apache/trafficcontrol/pull/6333


   Fixes a t3c nil reference panic and crash when a Traffic Ops request fails. 
   
   This is a very minor issue, because t3c is about to fail anyway, because it can't do anything if it can't get the data it needs from TO.
   
   No tests, there's no reasonable way to test this with unit or integration tests. The existing tests ensure normal usage still works.
   No docs, no interface change.
   No changelog, this is so minor it'd just clutter the changelog, and it didn't cause an actual failure.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Control Cache Config (T3C, formerly ORT)
   
   ## What is the best way to verify this PR?
   Run t3c pointed to a TO that fails to connect, verify t3c logs and exits the failure without a panic.
   
   
   ## If this is a bugfix, which Traffic Control versions contained the bug?
   - 6.0.0
   
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
   - [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #6333: Fix nil panic from using var when err exists

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6333:
URL: https://github.com/apache/trafficcontrol/pull/6333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #6333: Fix nil panic from using var when err exists

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6333:
URL: https://github.com/apache/trafficcontrol/pull/6333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [trafficcontrol] rawlinp merged pull request #6333: Fix nil panic from using var when err exists

Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6333:
URL: https://github.com/apache/trafficcontrol/pull/6333


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org