You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ja...@gmail.com> on 2020/07/03 14:23:25 UTC
[VOTE] [RELEASE] Apache OFBiz 17.12.04
This is the vote thread to publish a new bug fix release from the
"release17.12" branch. This new release, "Apache OFBiz 17.12.04", will
supersede all the previous releases from the same branch.
The release files can be downloaded from here:
https://dist.apache.org/repos/dist/dev/ofbiz/
and are:
* apache-ofbiz-17.12.04.zip
* KEYS: text file with keys
* apache-ofbiz-17.12.04.zip.asc: the detached signature file
* apache-ofbiz-17.12.04.zip.sha512: checksum file
Please download and test the zip file and its signatures (for instructions
on testing the signatures see http://www.apache.org/info/verification.html).
Vote:
[ +1] release as Apache OFBiz 17.12.04
[ -1] do not release
This vote will be open for 5 days.
For more details about this process please read
http://www.apache.org/foundation/voting.html
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Jacopo Cappellato <ja...@gmail.com>.
Thank you Michael and Jacques for your feedback and fixes.
This vote is cancelled, I am going to prepare new release files and start a
new vote thread.
Jacopo
On Sat, Jul 4, 2020 at 11:56 AM Jacques Le Roux <
jacques.le.roux@les7arts.com> wrote:
> Le 03/07/2020 à 19:31, Jacques Le Roux a écrit :
> > I see another issue locally, that exists also on R17 demo:
> >
> > 2020-07-03 03:10:02,911 |OFBiz-batch-2 |DatabaseUtil
> |E| Column [ACCOMMODATION_CLASS_ID] of table [OFBIZ.ACCOMMODATION_CLASS] of
> > entity [AccommodationClass] IS NOT a primary key in the database, but IS
> a primary key in the entity definition. The primary key for this table
> > needs to be re-created or modified to add this column to the primary
> key. Note that data may need to be added first as a primary key column
> cannot
> > have an null values.
> > [...]
> > 2020-07-03 03:10:03,092 |OFBiz-batch-2 |DatabaseUtil
> |E| Column [CITY] of table [OFBIZ.ZIP_SALES_TAX_LOOKUP] of entity
> > [ZipSalesTaxLookup] IS NOT a primary key in the database, but IS a
> primary key in the entity definition. The primary key for this table needs
> to be
> > re-created or modified to add this column to the primary key. Note that
> data may need to be added first as a primary key column cannot have an null
> > values.
> >
> > This does not exist in trunk, did not check R18.
> >
> > Weirdly it does not exist in Buildbot either for R17. Even before
> Michael's last fix for AJP. Anyway I don't use AJP locally nor does
> Buildbot.
> >
> > And finally it does not prevent the tests to pass.
>
> This is no longer a problem. I fixed it in OFBIZ-11312. I wrongly removed
> a line when backporting by hand in R17
>
> I see now no reasons to create a new "Tentative release files for Apache
> OFBiz 17.12.04"
>
> Thanks
>
> Jacques
>
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/07/2020 à 19:31, Jacques Le Roux a écrit :
> I see another issue locally, that exists also on R17 demo:
>
> 2020-07-03 03:10:02,911 |OFBiz-batch-2 |DatabaseUtil |E| Column [ACCOMMODATION_CLASS_ID] of table [OFBIZ.ACCOMMODATION_CLASS] of
> entity [AccommodationClass] IS NOT a primary key in the database, but IS a primary key in the entity definition. The primary key for this table
> needs to be re-created or modified to add this column to the primary key. Note that data may need to be added first as a primary key column cannot
> have an null values.
> [...]
> 2020-07-03 03:10:03,092 |OFBiz-batch-2 |DatabaseUtil |E| Column [CITY] of table [OFBIZ.ZIP_SALES_TAX_LOOKUP] of entity
> [ZipSalesTaxLookup] IS NOT a primary key in the database, but IS a primary key in the entity definition. The primary key for this table needs to be
> re-created or modified to add this column to the primary key. Note that data may need to be added first as a primary key column cannot have an null
> values.
>
> This does not exist in trunk, did not check R18.
>
> Weirdly it does not exist in Buildbot either for R17. Even before Michael's last fix for AJP. Anyway I don't use AJP locally nor does Buildbot.
>
> And finally it does not prevent the tests to pass.
This is no longer a problem. I fixed it in OFBIZ-11312. I wrongly removed a line when backporting by hand in R17
I see now no reasons to create a new "Tentative release files for Apache OFBiz 17.12.04"
Thanks
Jacques
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/07/2020 à 19:37, Jacques Le Roux a écrit :
> Le 03/07/2020 à 19:31, Jacques Le Roux a écrit :
>> I think we should mention that this is not a real issue referring to the corresponding Jiras.
> Forgot to mention it's OFBIZ-6807 and related
I just fixed a miss in OFBIZ-6993, should not be a worry anymore
Jacques
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Jacques Le Roux <ja...@les7arts.com>.
Le 03/07/2020 à 19:31, Jacques Le Roux a écrit :
> I think we should mention that this is not a real issue referring to the corresponding Jiras.
Forgot to mention it's OFBIZ-6807 and related
Jacques
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Jacques Le Roux <ja...@les7arts.com>.
-1 for now.
check OK:
$ ./verify-ofbiz-release.sh apache-ofbiz-17.12.04.zip
sha check of file: apache-ofbiz-17.12.04.zip
Using sha file: apache-ofbiz-17.12.04.zip.sha512
apache-ofbiz-17.12.04.zip: 74F79D42 2746A409 9C0F2E0D 5F96C070 78C73D7B 4C681452 EB974F18 33E2E391 3E1C7D1F 2F0E8A44 C18AC8FF A9F86094 4C9F5D4D
5DDA3AB9 E2DC2057 CA0F2E33
apache-ofbiz-17.12.04.zip: 74F79D42 2746A409 9C0F2E0D 5F96C070 78C73D7B 4C681452 EB974F18 33E2E391 3E1C7D1F 2F0E8A44 C18AC8FF A9F86094 4C9F5D4D
5DDA3AB9 E2DC2057 CA0F2E33
sha checksum OK
GPG verification output
gpg: Signature made Fri Jul 3 16:04:40 2020
gpg: using RSA key 7A580908847AF9E0
gpg: Good signature from "Jacopo Cappellato (CODE SIGNING KEY) <ja...@apache.org>"
Running OFBiz (gradlew loadAll ofbiz) is OK but I initially get:
2020-07-03 16:56:13,607 |catalina-startup-6 |CatalinaContainer |I|
host[StandardEngine[default-server].StandardHost[0.0.0.0]].addChild(StandardEngine[default-server].StandardHost[0.0.0.0].Standa
rdContext[/ecommerce])
Jul 03, 2020 4:56:13 PM org.apache.tomcat.util.digester.Digester error
SEVERE: Parse error at line [20] column [24]
org.xml.sax.SAXParseException; systemId:
file:///C:/projectsASF/Git/ofbiz-framework/tools/apache-ofbiz-17.12.04/applications/commonext/webapp/ordermgr-js/WEB-INF/web.xml; lineNumber: 20;
columnNumber: 24; cvc
-elt.1: Cannot find the declaration of element 'web-app'.
at org.apache.xerces.util.ErrorHandlerWrapper.createSAXParseException(Unknown Source)
I think we should mention that this is not a real issue referring to the corresponding Jiras. The same reappears when running testIntegration.
I see another issue locally, that exists also on R17 demo:
2020-07-03 03:10:02,911 |OFBiz-batch-2 |DatabaseUtil |E| Column [ACCOMMODATION_CLASS_ID] of table [OFBIZ.ACCOMMODATION_CLASS] of
entity [AccommodationClass] IS NOT a primary key in the database, but IS a primary key in the entity definition. The primary key for this table needs
to be re-created or modified to add this column to the primary key. Note that data may need to be added first as a primary key column cannot have an
null values.
[...]
2020-07-03 03:10:03,092 |OFBiz-batch-2 |DatabaseUtil |E| Column [CITY] of table [OFBIZ.ZIP_SALES_TAX_LOOKUP] of entity
[ZipSalesTaxLookup] IS NOT a primary key in the database, but IS a primary key in the entity definition. The primary key for this table needs to be
re-created or modified to add this column to the primary key. Note that data may need to be added first as a primary key column cannot have an null
values.
This does not exist in trunk, did not check R18.
Weirdly it does not exist in Buildbot either for R17. Even before Michael's last fix for AJP. Anyway I don't use AJP locally nor does Buildbot.
And finally it does not prevent the tests to pass.
I'm not sure what this is or if it's random. But it would certainly not look good to users's views. We need to understand what's the problem is.
I also found a bug in scrum/template/AcceptedBacklogNotification.ftl but that can wait.
Jacques
Le 03/07/2020 à 16:23, Jacopo Cappellato a écrit :
> This is the vote thread to publish a new bug fix release from the
> "release17.12" branch. This new release, "Apache OFBiz 17.12.04", will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-17.12.04.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.04.zip.asc: the detached signature file
> * apache-ofbiz-17.12.04.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.04
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Michael Brohl <mi...@ecomify.de>.
The fix is committed, please check.
Thanks,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 03.07.20 um 17:10 schrieb Michael Brohl:
> -1
>
> Hi Jacopo,
>
> we should first fix https://issues.apache.org/jira/browse/OFBIZ-11848
> which I had to reopen because of missing configuration which leads to
> not working AJP connections.
>
> I'll provide a fix soon.
>
> Best regards,
>
> Michael Brohl
>
> ecomify GmbH - www.ecomify.de
>
>
> Am 03.07.20 um 16:23 schrieb Jacopo Cappellato:
>> This is the vote thread to publish a new bug fix release from the
>> "release17.12" branch. This new release, "Apache OFBiz 17.12.04", will
>> supersede all the previous releases from the same branch.
>>
>> The release files can be downloaded from here:
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>> and are:
>> * apache-ofbiz-17.12.04.zip
>> * KEYS: text file with keys
>> * apache-ofbiz-17.12.04.zip.asc: the detached signature file
>> * apache-ofbiz-17.12.04.zip.sha512: checksum file
>>
>> Please download and test the zip file and its signatures (for
>> instructions
>> on testing the signatures see
>> http://www.apache.org/info/verification.html).
>>
>> Vote:
>> [ +1] release as Apache OFBiz 17.12.04
>> [ -1] do not release
>>
>> This vote will be open for 5 days.
>>
>> For more details about this process please read
>> http://www.apache.org/foundation/voting.html
>>
>
Re: [VOTE] [RELEASE] Apache OFBiz 17.12.04
Posted by Michael Brohl <mi...@ecomify.de>.
-1
Hi Jacopo,
we should first fix https://issues.apache.org/jira/browse/OFBIZ-11848
which I had to reopen because of missing configuration which leads to
not working AJP connections.
I'll provide a fix soon.
Best regards,
Michael Brohl
ecomify GmbH - www.ecomify.de
Am 03.07.20 um 16:23 schrieb Jacopo Cappellato:
> This is the vote thread to publish a new bug fix release from the
> "release17.12" branch. This new release, "Apache OFBiz 17.12.04", will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
> https://dist.apache.org/repos/dist/dev/ofbiz/
> and are:
> * apache-ofbiz-17.12.04.zip
> * KEYS: text file with keys
> * apache-ofbiz-17.12.04.zip.asc: the detached signature file
> * apache-ofbiz-17.12.04.zip.sha512: checksum file
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html).
>
> Vote:
> [ +1] release as Apache OFBiz 17.12.04
> [ -1] do not release
>
> This vote will be open for 5 days.
>
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>