You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Keith Wall (JIRA)" <ji...@apache.org> on 2011/08/23 12:26:29 UTC

[jira] [Created] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

0-10 code path hardcodes session timeout to 60 seconds.
-------------------------------------------------------

                 Key: QPID-3449
                 URL: https://issues.apache.org/jira/browse/QPID-3449
             Project: Qpid
          Issue Type: Improvement
          Components: Java Broker, Java Client
    Affects Versions: 0.10, 0.11, 0.12
            Reporter: Keith Wall
            Assignee: Robbie Gemmell


The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.

Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Resolved] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell resolved QPID-3449.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.13

Patch applied.

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>             Fix For: 0.13
>
>         Attachments: 0001-QPID-3449-adds-ability-to-override-the-session-timeo.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-3449:
---------------------------------

    Status: Open  (was: Ready To Review)

Putting this back to Open status, as it builds on the QPID-3448 which needs reworked. Also, the attempt to closing at the TCP level upon timeout might not actually accomplish this as the close method used will try use the connection normally to negotiate closure; this in itself may also timeout.

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Attachment:     (was: QPID-3449-adds-ability-to-override-the-session-timeout.patch)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-3449:
------------------------------------

    Assignee: Alex Rudyy  (was: Robbie Gemmell)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-3449:
--------------------------------

    Assignee: Robbie Gemmell  (was: Alex Rudyy)

Robbie, could you please review an updated version of patch?

A newly introduced by previous patch SessionTimeoutException was removed.
Also, connection closure was removed as well.

SyncWaitTimeoutDelayTest and SyncWaitDelatTest were not enabled as SyncWaitTimeoutDelayTest requires more work.

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Status: Ready To Review  (was: In Progress)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Attachment:     (was: QPID-3449-adds-ability-to-override-the-session-timeout.patch)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Attachment: QPID-3449-adds-ability-to-override-the-session-timeout.patch

Patch changes transport Session to use timeout value specified via JVM settings "qpid.sync_op_timeout" or "amqj.default_syncwrite_timeout.
This patch enables tests SyncWaitTimeoutDelayTest and SyncWaitDelayTest

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Attachment: QPID-3449-adds-ability-to-override-the-session-timeout.patch

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Attachment: 0001-QPID-3449-adds-ability-to-override-the-session-timeo.patch

Attached a new patch from me and Robbie.

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>         Attachments: 0001-QPID-3449-adds-ability-to-override-the-session-timeo.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-3449:
--------------------------------

    Assignee: Alex Rudyy  (was: Robbie Gemmell)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Assigned] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy reassigned QPID-3449:
--------------------------------

    Assignee: Robbie Gemmell  (was: Alex Rudyy)

Robbie, could you please review this patch?

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Robbie Gemmell
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] [Updated] (QPID-3449) 0-10 code path hardcodes session timeout to 60 seconds.

Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-3449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Rudyy updated QPID-3449:
-----------------------------

    Status: Ready To Review  (was: In Progress)

> 0-10 code path hardcodes session timeout to 60 seconds.
> -------------------------------------------------------
>
>                 Key: QPID-3449
>                 URL: https://issues.apache.org/jira/browse/QPID-3449
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>    Affects Versions: 0.10, 0.11, 0.12
>            Reporter: Keith Wall
>            Assignee: Alex Rudyy
>         Attachments: QPID-3449-adds-ability-to-override-the-session-timeout.patch
>
>
> The 0-10 code path has a hardcoded timeout value (Session#timeout) used to enforce a maximum time permitted for Method invocation (Session#invoke) and sync (Session#sync).  This value is 60,000ms.
> Users should have the ability to override this setting on both broker and client side in order that they have flexibility to deal with issues such as slow WAN, contended storage etc that may require this parameter to be tuned.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org