You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by cvlchinet <gi...@git.apache.org> on 2014/11/13 22:34:11 UTC

[GitHub] thrift pull request: node.js WebSocket client

GitHub user cvlchinet opened a pull request:

    https://github.com/apache/thrift/pull/265

    node.js WebSocket client

    I needed a WebSocket client for node.js and implemented it.
    I am sharing my code with the community:
    
    This PR adds a WebSocket client to the node.js library.
    It is a combination of http_connection.js and the WebSocket implementation from js.
    Adds dependency to https://github.com/einaros/ws
    Includes integration tests.
    
    It only works with TJSONProtocol and TBufferedTransport because sending raw binary data on a WebSocket currently causes an UTF8 error.
    Maybe it is possible to fix?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cvlchinet/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit 29a22a41e1de218697cca94b07ff6445c702c7f0
Author: Chi Vinh Le <cv...@chinet.info>
Date:   2014-11-13T21:03:53Z

    node.js WebSocket client

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2819 - Add WebsSocket client to node.j...

Posted by cvlchinet <gi...@git.apache.org>.
Github user cvlchinet closed the pull request at:

    https://github.com/apache/thrift/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2819 - Add WebsSocket client to node.j...

Posted by cvlchinet <gi...@git.apache.org>.
Github user cvlchinet commented on the pull request:

    https://github.com/apache/thrift/pull/265#issuecomment-63179959
  
    I added binary support to client and to the web server. Now all integration tests pass.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---