[GitHub] [hudi] nsivabalan commented on a change in pull request #1712: Cherry picking HUDI-988 and HUDI-990 to release-0.5.3

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #1712:
URL: https://github.com/apache/hudi/pull/1712#discussion_r436940846



##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/AbstractShellIntegrationTest.java
##########
@@ -58,4 +58,13 @@ public void teardown() throws Exception {
   protected static JLineShellComponent getShell() {
     return shell;
   }
-}
\ No newline at end of file
+
+  /**
+   * Helper to prepare string for matching.
+   * @param str Input string.
+   * @return pruned string with non word characters removed.

Review comment:
       this method is not used only. This are used by TestClasses which are not added to 0.5.3. 

##########
File path: hudi-cli/src/test/java/org/apache/hudi/cli/commands/TestRepairsCommand.java
##########
@@ -95,8 +95,9 @@ public void testAddPartitionMetaWithDryRun() throws IOException {
         .toArray(String[][]::new);
     String expected = HoodiePrintHelper.print(new String[] {HoodieTableHeaderFields.HEADER_PARTITION_PATH,
         HoodieTableHeaderFields.HEADER_METADATA_PRESENT, HoodieTableHeaderFields.HEADER_REPAIR_ACTION}, rows);
-
-    assertEquals(expected, cr.getResult().toString());
+    expected = removeNonWordAndStripSpace(expected);

Review comment:
       Actually I added this entire class TestRepairsCommand by mistake. 0.5.3 doesn't pull in HUDI-704 and hence have I have deleted this file in my latest commit. 

##########
File path: hudi-client/src/test/java/org/apache/hudi/index/TestHoodieIndex.java
##########
@@ -43,9 +44,11 @@ public void setUp() throws Exception {
   }
 
   @After
-  public void tearDown() {
+  public void tearDown() throws IOException {
     cleanupSparkContexts();
-    cleanupMetaClient();
+    cleanupFileSystem();

Review comment:
       cleanupFileSystem and cleanupTestDataGenerator was added as part of SimpleHoodieIndex. These are not required as per 0.5.3. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org