[kudu-CR] [java] KUDU-1563. Add support for INSERT IGNORE

["Brock Noland (Code Review)" <ge...@cloudera.org>]

Brock Noland has posted comments on this change.

Change subject: [java] KUDU-1563. Add support for INSERT IGNORE
......................................................................


Patch Set 7:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java
File java/kudu-client/src/main/java/org/apache/kudu/client/InsertIgnore.java:

Line 18: 
> nit: extra line
Done


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java:

PS7, Line 140: insert ignore
> I think this could be documented better, like how exactly is this "ignore" 
Done


http://gerrit.cloudera.org:8080/#/c/4523/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java:

PS7, Line 225: final
> nit: doesn't need to be final.
Done


PS7, Line 227: t
> nit: end code comments with periods.
Done


PS7, Line 237: r
> same
Done


Line 244:   }
> Could be interesting in the clients to test mixing different types of opera
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/4523
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0cc4a533dfb01a883d347c9795c165aa8efa3fd
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Brock Noland <br...@phdata.io>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes