[jira] Resolved: (WICKET-545) Improve check for components added to AJAX response in WicketTester

["Gerolf Seitz (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gerolf Seitz resolved WICKET-545.
---------------------------------

    Resolution: Fixed

if you forget to setOutputMarkupId(true), an exception will be thrown, so this doesn't need to be checked.

i added a check if the component is invisible and outputmarkupplaceholdertag is not set to true.

> Improve check for components added to AJAX response in WicketTester
> -------------------------------------------------------------------
>
>                 Key: WICKET-545
>                 URL: https://issues.apache.org/jira/browse/WICKET-545
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.6, 1.3.0-beta1
>            Reporter: Jordi Salvat i Alabart
>            Assignee: Gerolf Seitz
>             Fix For: 1.3.0-rc3
>
>
> The javadoc for wicket.util.tester.WicketTester.assertComponentOnAjaxResponse makes this statement:
> "This method doesn't actually insert the component in the client DOM tree, using javascript. But it shouldn't be needed because you have to trust that the Wicket Ajax Javascript just works."
> Turns out that there is another way to have the component replacement fail, which is to forget to setOutputMarkupId(true) or to setVisible(false).
> I propose to improve this method to at least check that the component's markup id made it into the page, or at least that the component isOutputMarkupId and isVisible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.