[jira] Commented: (HDFS-536) Support hflush at DFSClient

["Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742143#action_12742143 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-536:
---------------------------------------------

- The patch adds a response.close().  Should we use closeResponder() instead of response.close()?  Or should we remove the later closeResponder() call?

- 
{code}
             if (streamerClosed || hasError || !clientRunning) {
               continue;
             }
{code}
There are a few above if-statements in run().  It looks like that some of them are not necessary.

- How about remove sync() javadoc or change it to "Same as hflush()"?  Otherwise, there are two different javadocs on the same implementation. 

- {code}+     * @deprecated use #hflush() instead{code}
There is an additional '#'.

- Suresh suggest that hadoop version should be added in the javadoc when an api is deprecated.

> Support hflush at DFSClient
> ---------------------------
>
>                 Key: HDFS-536
>                 URL: https://issues.apache.org/jira/browse/HDFS-536
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs client
>    Affects Versions: Append Branch
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: Append Branch
>
>         Attachments: hdfsHflush.patch
>
>
> 1. Add hflush() API to DFSOutputStream and deprecate sync();
> 2. Make pipeline close wait until the ack for the last packet is received.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.