You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/07/30 18:29:34 UTC
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #489: remove shaded protobuf-java v2 jar (pekko-protobuf)
pjfanning commented on code in PR #489:
URL: https://github.com/apache/incubator-pekko/pull/489#discussion_r1278601297
##########
LICENSE:
##########
@@ -353,12 +353,6 @@ Copyright 2014 - 2016 Real Logic Ltd.
---------------
-pekko-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
Review Comment:
We don't have the sources of protobuf-java v3 copied into our code base. With protobuf-java v3, sbt-assembly is used to take the official google jar and to produce a new pekko-protobuf-v3 jar with shaded package names. The LICENSE file accounts for source code. We have the `legal` folder where we have specific LICENSE files that we add to our jars. There is one of those for pekko-protobuf-v3 jar that acknowledges that the classes are derived from Google classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org