You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by mi...@apache.org on 2020/04/19 19:24:34 UTC
[maven-wagon] 01/03: Add TODOs
This is an automated email from the ASF dual-hosted git repository.
michaelo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit b717f607cf7ea4a7b6c76ce9e61d04807eb72e75
Author: Michael Osipov <mi...@apache.org>
AuthorDate: Sun Apr 19 21:06:11 2020 +0200
Add TODOs
---
.../org/apache/maven/wagon/providers/http/LightweightHttpWagon.java | 3 +++
.../org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java | 3 +++
.../src/main/java/org/apache/maven/wagon/providers/http/HttpWagon.java | 1 +
3 files changed, 7 insertions(+)
diff --git a/wagon-providers/wagon-http-lightweight/src/main/java/org/apache/maven/wagon/providers/http/LightweightHttpWagon.java b/wagon-providers/wagon-http-lightweight/src/main/java/org/apache/maven/wagon/providers/http/LightweightHttpWagon.java
index 82981c9..d4910e5 100644
--- a/wagon-providers/wagon-http-lightweight/src/main/java/org/apache/maven/wagon/providers/http/LightweightHttpWagon.java
+++ b/wagon-providers/wagon-http-lightweight/src/main/java/org/apache/maven/wagon/providers/http/LightweightHttpWagon.java
@@ -169,6 +169,7 @@ public class LightweightHttpWagon
int responseCode = urlConnection.getResponseCode();
String reasonPhrase = urlConnection.getResponseMessage();
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
if ( responseCode == HttpURLConnection.HTTP_FORBIDDEN
|| responseCode == HttpURLConnection.HTTP_UNAUTHORIZED
|| responseCode == HttpURLConnection.HTTP_PROXY_AUTH )
@@ -277,6 +278,7 @@ public class LightweightHttpWagon
case HttpURLConnection.HTTP_NO_CONTENT: // 204
break;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpURLConnection.HTTP_FORBIDDEN:
case HttpURLConnection.HTTP_UNAUTHORIZED:
case HttpURLConnection.HTTP_PROXY_AUTH:
@@ -454,6 +456,7 @@ public class LightweightHttpWagon
case HttpURLConnection.HTTP_NOT_FOUND:
return false;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpURLConnection.HTTP_UNAUTHORIZED:
case HttpURLConnection.HTTP_PROXY_AUTH:
throw new AuthorizationException( "Access denied to: " + url );
diff --git a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
old mode 100755
new mode 100644
index 81d56d5..e0bb164
--- a/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
+++ b/wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
@@ -794,6 +794,7 @@ public abstract class AbstractHttpClientWagon
case HttpStatus.SC_NO_CONTENT: // 204
break;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpStatus.SC_FORBIDDEN:
case HttpStatus.SC_UNAUTHORIZED:
case HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED:
@@ -875,6 +876,7 @@ public abstract class AbstractHttpClientWagon
result = true;
break;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpStatus.SC_FORBIDDEN:
case HttpStatus.SC_UNAUTHORIZED:
case HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED:
@@ -1158,6 +1160,7 @@ public abstract class AbstractHttpClientWagon
// return, leaving last modified set to original value so getIfNewer should return unmodified
return;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpStatus.SC_FORBIDDEN:
case HttpStatus.SC_UNAUTHORIZED:
case HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED:
diff --git a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpWagon.java b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpWagon.java
old mode 100755
new mode 100644
index 532141c..08dc803
--- a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpWagon.java
+++ b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpWagon.java
@@ -80,6 +80,7 @@ public class HttpWagon
case HttpStatus.SC_OK:
break;
+ // TODO Move 401/407 to AuthenticationException after WAGON-587
case HttpStatus.SC_FORBIDDEN:
case HttpStatus.SC_UNAUTHORIZED:
case HttpStatus.SC_PROXY_AUTHENTICATION_REQUIRED: