You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@guacamole.apache.org by mj...@apache.org on 2018/02/05 03:09:28 UTC
[6/8] guacamole-client git commit: GUACAMOLE-197: Brush up log
messages and change levels for invalid state information.
GUACAMOLE-197: Brush up log messages and change levels for invalid state information.
Project: http://git-wip-us.apache.org/repos/asf/guacamole-client/repo
Commit: http://git-wip-us.apache.org/repos/asf/guacamole-client/commit/b9a68804
Tree: http://git-wip-us.apache.org/repos/asf/guacamole-client/tree/b9a68804
Diff: http://git-wip-us.apache.org/repos/asf/guacamole-client/diff/b9a68804
Branch: refs/heads/master
Commit: b9a68804709bcb71d46b3ba8ee312821fbd705dd
Parents: ef6d0c6
Author: Nick Couchman <vn...@apache.org>
Authored: Sun Feb 4 09:31:47 2018 -0500
Committer: Nick Couchman <vn...@apache.org>
Committed: Sun Feb 4 09:31:47 2018 -0500
----------------------------------------------------------------------
.../guacamole/auth/radius/AuthenticationProviderService.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/guacamole-client/blob/b9a68804/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
----------------------------------------------------------------------
diff --git a/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java b/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
index 2418c8e..6301734 100644
--- a/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
+++ b/extensions/guacamole-auth-radius/src/main/java/org/apache/guacamole/auth/radius/AuthenticationProviderService.java
@@ -160,8 +160,7 @@ public class AuthenticationProviderService {
try {
String stateString = request.getParameter(RadiusStateField.PARAMETER_NAME);
if (stateString == null) {
- logger.error("Could not retrieve RADIUS state.");
- logger.debug("Received null value while retrieving RADIUS state parameter.");
+ logger.warn("Expected state parameter was not present in challenge/response.");
throw new GuacamoleInvalidCredentialsException("Authentication error.", CredentialsInfo.USERNAME_PASSWORD);
}
@@ -171,8 +170,8 @@ public class AuthenticationProviderService {
stateBytes);
}
catch (IllegalArgumentException e) {
- logger.error("Illegal argument while parsing RADIUS state string.", e.getMessage());
- logger.debug("Illegal argument found while parsing the RADIUS state string.", e);
+ logger.warn("Illegal hexadecimal value while parsing RADIUS state string.", e.getMessage());
+ logger.debug("Encountered exception while attepmting to perse the hexidecimanl state value.", e);
throw new GuacamoleInvalidCredentialsException("Authentication error.", CredentialsInfo.USERNAME_PASSWORD);
}
catch (GuacamoleException e) {