You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Pavel Afremov (JIRA)" <ji...@apache.org> on 2007/12/29 15:53:43 UTC
[jira] Created: (HARMONY-5360) [drlvm][thread] Suspend enable /
disable mismatch in jthread function.
[drlvm][thread] Suspend enable / disable mismatch in jthread function.
----------------------------------------------------------------------
Key: HARMONY-5360
URL: https://issues.apache.org/jira/browse/HARMONY-5360
Project: Harmony
Issue Type: Bug
Components: DRLVM
Reporter: Pavel Afremov
Priority: Minor
Suspend enable / disable mismatch in jthread function.
I found following bug during ...\vm\vmcore\src\thread\thread_java_monitors.cpp code review.
Function jthread_throw_exception should be called in suspend disable mode only. But it can be called form jthread_monitor_exit, which can works in suspend disable and in suspend enable mode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5360) [drlvm][thread] Suspend enable /
disable mismatch in jthread function.
Posted by "Chengrui Deng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627942#action_12627942 ]
Chengrui Deng commented on HARMONY-5360:
----------------------------------------
Below is the code of jthread_throw_exception:
IDATA jthread_throw_exception(char *name, char *message)
{
assert(hythread_is_suspend_enabled());
jobject jthe = exn_create(name);
return jthread_throw_exception_object(jthe);
}
We can see that assertion is used to assure jthread_throw_exception should be called in suspend enable mode only. So I think this issue is actually not an issue.
> [drlvm][thread] Suspend enable / disable mismatch in jthread function.
> ----------------------------------------------------------------------
>
> Key: HARMONY-5360
> URL: https://issues.apache.org/jira/browse/HARMONY-5360
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Pavel Afremov
> Priority: Minor
>
> Suspend enable / disable mismatch in jthread function.
> I found following bug during ...\vm\vmcore\src\thread\thread_java_monitors.cpp code review.
> Function jthread_throw_exception should be called in suspend disable mode only. But it can be called form jthread_monitor_exit, which can works in suspend disable and in suspend enable mode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5360) [drlvm][thread] Suspend enable /
disable mismatch in jthread function.
Posted by "Xiao-Feng Li (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628223#action_12628223 ]
Xiao-Feng Li commented on HARMONY-5360:
---------------------------------------
I am confused. :)
The issue says:
"Function jthread_throw_exception should be called in suspend disable mode only. "
But the code in jthread_throw_exception() has:
"assert(hythread_is_suspend_enabled()); "
This is an obvious contradiction. What is the problem??
I guess we can think about it in the exception-throwing semantics, whether it "should be" enabled or disabled mode. And even if it should be enabled, an assertion does not really ensure that.
Thanks.
> [drlvm][thread] Suspend enable / disable mismatch in jthread function.
> ----------------------------------------------------------------------
>
> Key: HARMONY-5360
> URL: https://issues.apache.org/jira/browse/HARMONY-5360
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Reporter: Pavel Afremov
> Priority: Minor
>
> Suspend enable / disable mismatch in jthread function.
> I found following bug during ...\vm\vmcore\src\thread\thread_java_monitors.cpp code review.
> Function jthread_throw_exception should be called in suspend disable mode only. But it can be called form jthread_monitor_exit, which can works in suspend disable and in suspend enable mode.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.