You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/24 21:10:38 UTC
[GitHub] [spark] viirya opened a new pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
viirya opened a new pull request #30921:
URL: https://github.com/apache/spark/pull/30921
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
As a follow-up task to SPARK-32958, this patch takes safer approach to only prune columns from `JsonToStructs` if the parsing option is empty. It is to avoid unexpected behavior change regarding parsing.
This patch also adds a few e2e tests to make sure failfast parsing behavior is not changed.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
It is to avoid unexpected behavior change regarding parsing.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30921:
URL: https://github.com/apache/spark/pull/30921#discussion_r548751016
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -82,12 +82,12 @@ object OptimizeJsonExprs extends Rule[LogicalPlan] {
child
case g @ GetStructField(j @ JsonToStructs(schema: StructType, _, _, _), ordinal, _)
- if schema.length > 1 =>
+ if schema.length > 1 && j.options.isEmpty =>
Review comment:
Ur, you should not use `[TEST]` tag when you touch `src/main`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751087765
**[Test build #133361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133361/testReport)** for PR 30921 at commit [`63887f5`](https://github.com/apache/spark/commit/63887f5f099ddf3ff790ba877849ec344ad7b2e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751127222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751102304
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751102220
**[Test build #133361 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133361/testReport)** for PR 30921 at commit [`63887f5`](https://github.com/apache/spark/commit/63887f5f099ddf3ff790ba877849ec344ad7b2e8).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751125197
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751193499
late lgtm. Happy Merry Christmas, @viirya ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751111106
> I don't see `SPARK-33907` in `master` branch. Let's proceed `master` branch first, @viirya .
Okay. Because the change here will conflict with #30912, so I submit to branch-3.1 first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751125139
Yea, Merry Christmas and Happy new year @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751195826
Thanks @maropu, Merry Christmas!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751127216
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751123722
Merry Christmas and Happy New Year, @viirya !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751113538
I will submit the change for master branch after #30912 gets merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751127222
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37952/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751044090
cc @HyukjinKwon @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30921:
URL: https://github.com/apache/spark/pull/30921
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30921:
URL: https://github.com/apache/spark/pull/30921#discussion_r548754674
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/OptimizeJsonExprs.scala
##########
@@ -82,12 +82,12 @@ object OptimizeJsonExprs extends Rule[LogicalPlan] {
child
case g @ GetStructField(j @ JsonToStructs(schema: StructType, _, _, _), ordinal, _)
- if schema.length > 1 =>
+ if schema.length > 1 && j.options.isEmpty =>
Review comment:
Removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751087765
**[Test build #133361 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/133361/testReport)** for PR 30921 at commit [`63887f5`](https://github.com/apache/spark/commit/63887f5f099ddf3ff790ba877849ec344ad7b2e8).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30921: [SPARK-33907][SQL][TEST][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751102304
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/133361/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #30921: [SPARK-33907][SQL][3.1] Only prune columns of JsonToStructs if parsing options is empty.
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #30921:
URL: https://github.com/apache/spark/pull/30921#issuecomment-751123172
Thanks @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org