You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/19 18:21:19 UTC

[GitHub] [iceberg] stevenzwu commented on pull request #5576: API: Extend FileIO in optional interfaces

stevenzwu commented on PR #5576:
URL: https://github.com/apache/iceberg/pull/5576#issuecomment-1220973805

   @aokolnychyi this doesn't seem to be a problem in current code. I assume you ran into this need of casting in some new code you are working on?
   
   I found the interface name of `SupportsPrefixOperations`  less intuitive for an interface extending from `FileIO`. Supports just meant some extra capability.  can't connect `Supports...` as an extended interface of `FileIO`.
   
   Another downside is that `S3FileIO` would need to implement both `SupportsBulkOperations` and `SupportsPrefixOperations` with large overlap of base `FileIO` interface. not a problem for compiler. just thought a little odd.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org