You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2005/04/05 16:52:28 UTC
[jira] Created: (JCR-96) Improve NodetypeRegistry
Improve NodetypeRegistry
------------------------
Key: JCR-96
URL: http://issues.apache.org/jira/browse/JCR-96
Project: Jackrabbit
Type: Improvement
Components: nodetype
Reporter: angela
hi
as discussed earlier (before easter)
1)
- rename NodeTypeRegistry to NodeTypeRegistryImpl
- extract interface NodeTypeRegistry
- used interface instead of implementing class (except where registry is created
and in the dump in NodeTypeManagerImpl.
2)
- provide second static create method that allows to create a nodetype registry
remotely, where no xml-storage exists.
attached: diff (it looks garbled... don't know why...).
1) is trivial....
2) you would probably want a different appraoch.
btw: in addition i modified:
- rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
- in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
thanks
angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-96) Improve NodetypeRegistry
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-96?page=comments#action_62180 ]
Stefan Guggisberg commented on JCR-96:
--------------------------------------
a diff of 153 kb is pretty big for a trivial change ;)
changes seem to be ok except the additional constructor
factory method in NodeTypeRegistryImpl...
i will take a look at it...
> Improve NodetypeRegistry
> ------------------------
>
> Key: JCR-96
> URL: http://issues.apache.org/jira/browse/JCR-96
> Project: Jackrabbit
> Type: Improvement
> Components: nodetype
> Reporter: angela
> Assignee: Stefan Guggisberg
> Attachments: nodetyperegistry.diff
>
> hi
> as discussed earlier (before easter)
> 1)
> - rename NodeTypeRegistry to NodeTypeRegistryImpl
> - extract interface NodeTypeRegistry
> - used interface instead of implementing class (except where registry is created
> and in the dump in NodeTypeManagerImpl.
> 2)
> - provide second static create method that allows to create a nodetype registry
> remotely, where no xml-storage exists.
> attached: diff (it looks garbled... don't know why...).
> 1) is trivial....
> 2) you would probably want a different appraoch.
> btw: in addition i modified:
> - rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
> - in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
> thanks
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Assigned: (JCR-96) Improve NodetypeRegistry
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-96?page=history ]
Stefan Guggisberg reassigned JCR-96:
------------------------------------
Assign To: Stefan Guggisberg
> Improve NodetypeRegistry
> ------------------------
>
> Key: JCR-96
> URL: http://issues.apache.org/jira/browse/JCR-96
> Project: Jackrabbit
> Type: Improvement
> Components: nodetype
> Reporter: angela
> Assignee: Stefan Guggisberg
> Attachments: nodetyperegistry.diff
>
> hi
> as discussed earlier (before easter)
> 1)
> - rename NodeTypeRegistry to NodeTypeRegistryImpl
> - extract interface NodeTypeRegistry
> - used interface instead of implementing class (except where registry is created
> and in the dump in NodeTypeManagerImpl.
> 2)
> - provide second static create method that allows to create a nodetype registry
> remotely, where no xml-storage exists.
> attached: diff (it looks garbled... don't know why...).
> 1) is trivial....
> 2) you would probably want a different appraoch.
> btw: in addition i modified:
> - rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
> - in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
> thanks
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Closed: (JCR-96) Improve NodetypeRegistry
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-96?page=all ]
Stefan Guggisberg closed JCR-96:
--------------------------------
Resolution: Won't Fix
the changes of r161889 improved reusability of
NodeTypeRegistry and made the suggested modifications unnecessary
> Improve NodetypeRegistry
> ------------------------
>
> Key: JCR-96
> URL: http://issues.apache.org/jira/browse/JCR-96
> Project: Jackrabbit
> Type: Improvement
> Components: nodetype
> Reporter: angela
> Assignee: Stefan Guggisberg
> Attachments: nodetyperegistry.diff
>
> hi
> as discussed earlier (before easter)
> 1)
> - rename NodeTypeRegistry to NodeTypeRegistryImpl
> - extract interface NodeTypeRegistry
> - used interface instead of implementing class (except where registry is created
> and in the dump in NodeTypeManagerImpl.
> 2)
> - provide second static create method that allows to create a nodetype registry
> remotely, where no xml-storage exists.
> attached: diff (it looks garbled... don't know why...).
> 1) is trivial....
> 2) you would probably want a different appraoch.
> btw: in addition i modified:
> - rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
> - in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
> thanks
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (JCR-96) Improve NodetypeRegistry
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-96?page=comments#action_62184 ]
angela commented on JCR-96:
---------------------------
trivial to make with a reasonable ide... i got the impression you are afraid of the refactoring ;)... thus only a little encouragement...
> Improve NodetypeRegistry
> ------------------------
>
> Key: JCR-96
> URL: http://issues.apache.org/jira/browse/JCR-96
> Project: Jackrabbit
> Type: Improvement
> Components: nodetype
> Reporter: angela
> Assignee: Stefan Guggisberg
> Attachments: nodetyperegistry.diff
>
> hi
> as discussed earlier (before easter)
> 1)
> - rename NodeTypeRegistry to NodeTypeRegistryImpl
> - extract interface NodeTypeRegistry
> - used interface instead of implementing class (except where registry is created
> and in the dump in NodeTypeManagerImpl.
> 2)
> - provide second static create method that allows to create a nodetype registry
> remotely, where no xml-storage exists.
> attached: diff (it looks garbled... don't know why...).
> 1) is trivial....
> 2) you would probably want a different appraoch.
> btw: in addition i modified:
> - rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
> - in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
> thanks
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (JCR-96) Improve NodetypeRegistry
Posted by "angela (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/JCR-96?page=history ]
angela updated JCR-96:
----------------------
Attachment: nodetyperegistry.diff
> Improve NodetypeRegistry
> ------------------------
>
> Key: JCR-96
> URL: http://issues.apache.org/jira/browse/JCR-96
> Project: Jackrabbit
> Type: Improvement
> Components: nodetype
> Reporter: angela
> Attachments: nodetyperegistry.diff
>
> hi
> as discussed earlier (before easter)
> 1)
> - rename NodeTypeRegistry to NodeTypeRegistryImpl
> - extract interface NodeTypeRegistry
> - used interface instead of implementing class (except where registry is created
> and in the dump in NodeTypeManagerImpl.
> 2)
> - provide second static create method that allows to create a nodetype registry
> remotely, where no xml-storage exists.
> attached: diff (it looks garbled... don't know why...).
> 1) is trivial....
> 2) you would probably want a different appraoch.
> btw: in addition i modified:
> - rename 'NodeTypeRegistry ntMgr' to 'NodeTypeRegistry ntReg' in the create methods.
> - in dump changed 'NodeTypeManager (this)' to 'NodeTypeRegistry (this)'
> thanks
> angela
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira