[GitHub] [flink] tillrohrmann commented on a change in pull request #10364: [FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #10364: [FLINK-14993][metrics] FrontMetricGroup passes reporter-specific parameters
URL: https://github.com/apache/flink/pull/10364#discussion_r354950005
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
 ##########
 @@ -147,14 +145,18 @@ public MetricRegistryImpl(MetricRegistryConfiguration config, Collection<Reporte
 					} else {
 						LOG.info("Reporting metrics for reporter {} of type {}.", namedReporter, className);
 					}
-					reporters.add(new ReporterAndSettings(reporterInstance, new ReporterScopedSettings(reporters.size() - 1)));
 
 					String delimiterForReporter = reporterSetup.getDelimiter().orElse(String.valueOf(globalDelimiter));
 					if (delimiterForReporter.length() != 1) {
 						LOG.warn("Failed to parse delimiter '{}' for reporter '{}', using global delimiter '{}'.", delimiterForReporter, namedReporter, globalDelimiter);
 						delimiterForReporter = String.valueOf(globalDelimiter);
 					}
-					this.delimiters.add(delimiterForReporter.charAt(0));
+
+					reporters.add(new ReporterAndSettings(
+						reporterInstance,
+						new ReporterScopedSettings(
+							reporters.size() - 1,
 
 Review comment:
   If this is incorrect, then I would suggest to add a test to guard against future regressions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services