You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/22 05:18:23 UTC

[GitHub] [netbeans] mbien opened a new pull request, #4999: upgrade to maven-indexer 7.0.0

mbien opened a new pull request, #4999:
URL: https://github.com/apache/netbeans/pull/4999

   wip
   
   upgrade to maven-indexer 7.0.0. (NetBeans entered the modern era! :-) )
   
    - module requires now jdk 11+
    - apache lucene 9.4.1 with memory mapped index
    - can use panama on JDK 19+ if started with `--enable-preview`
    - multi-threaded remote index extraction (at least twice as fast as ST)
    - bugfix backport hack removed
    - no EOL libs anymore in this module
   
   remote index extraction takes about 8 minutes on my system (4 cores, hyperthreading off).
   local `.m2` indexing speed is about the same
   
   note: tmp files aren't cleaned up properly atm. This might fill up your tmp during testing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] vieiro commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529115205

   Hi @mbien,
   
   I have no remote URLs to download from:
   
   ![imagen](https://user-images.githubusercontent.com/564140/235371168-31768122-5e07-426a-8e2b-1f41c22b6125.png)
   
   Is this as expected? How do I add one?
   
   On other news, here's some stuff from my stdout (question: are we expected to System.out all artifacts in the local repo?)
   
   ```
   ...
        [exec] [Maven Repo Index Transfer/Scan] INFO org.eclipse.aether.internal.impl.DefaultArtifactResolver - Artifact org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-bom:pom:2.0.0 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [central (https://repo.maven.apache.org/maven2, default, releases)]
        [exec] [Maven Repo Index Transfer/Scan] INFO org.eclipse.aether.internal.impl.DefaultArtifactResolver - Artifact org.jboss.shrinkwrap.resolver:shrinkwrap-resolver-bom:pom:3.1.4 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [central (https://repo.maven.apache.org/maven2/, default, releases+snapshots)]
        [exec] [Maven Repo Index Transfer/Scan] INFO org.eclipse.aether.internal.impl.DefaultArtifactResolver - Artifact org.jboss.shrinkwrap.descriptors:shrinkwrap-descriptors-bom:pom:2.0.0 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [central (https://repo.maven.apache.org/maven2/, default, releases+snapshots)]
        [exec] [Maven Repo Index Transfer/Scan] INFO org.eclipse.aether.internal.impl.DefaultArtifactResolver - Artifact org.jboss.shrinkwrap:shrinkwrap-bom:pom:1.2.6 is present in the local repository, but cached from a remote repository ID that is unavailable in current build context, verifying that is downloadable from [central (https://repo.maven.apache.org/maven2/, default, releases+snapshots)]
        [exec] INFO [org.netbeans.modules.maven.indexer.NexusRepositoryIndexerImpl]: Indexing of local took 18,09 s.
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] vieiro commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529982051

   Great job, @mbien! 
   
   There's a "gobally" -> "globally" typo you may want to take a look at before merging.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1535671395

   merging earlier than planned since I got some time for testing and the next steps (search service/filters)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] vieiro commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "vieiro (via GitHub)" <gi...@apache.org>.
vieiro commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529120791

   > @vieiro this is a list of user given permissions. Try opening a pom or something which triggers indexing (e.g add dependency to a project via UI), nb will then show a notification, based on what you answer it will show up in the list. You don't have to change anything on the list unless you want to change the permission in post.
   
   Hi @mbien , thanks for the tip!
   
   Works perfect now. I've tried to unpack the maven index from central, after a few minutes with fans at top speed and ~3.9Gb `var/cache/mavenindex/` I decided to cancel it, and it's now disabled forever! Thanks very much for this! 
   
   ![imagen](https://user-images.githubusercontent.com/564140/235372402-ba650dd9-f5de-473b-8198-5f3db54ad7c1.png)
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1530957842

   last commit removes the `never` update frequency. Typo is fixed too but already squashed.
   
   planning to squash it into two commits before merge


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1446238910

   bump to maven-indexer 7.0.1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien merged pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #4999:
URL: https://github.com/apache/netbeans/pull/4999


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#discussion_r1181330522


##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -702,6 +723,25 @@ public void indexRepo(final RepositoryInfo repo) {
         }
 
     }
+    
+    private static boolean shouldSkipIndexRequest(RepositoryInfo repo) {
+        if (repo.isRemoteDownloadable()) {
+            if (!RepositoryPreferences.isIndexDownloadEnabledEffective()) {
+                return true;
+            }
+            if (RepositoryPreferences.isIndexDownloadDeniedFor(repo)) {
+                return true;
+            }
+            if (!RepositoryPreferences.isIndexDownloadAllowedFor(repo)) {
+                IndexingNotificationProvider np = Lookup.getDefault().lookup(IndexingNotificationProvider.class);
+                if(np != null) {
+                    np.requestPermissionsFor(repo);
+                }
+                return true;

Review Comment:
   i thought about returning false when no `IndexingNotificationProvider` is found. But it is probably better to add a dummy implementation which simply allows everything. Once all users of this API have their own implementation, the dummy can be removed.
   
   I think it is a better behavior to not a allow downloads by default if there is no provider.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] matthiasblaesing commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529851939

   I think this is mostly good to go. The only thing missing is IMHO restoring periodic updates. Given, that you now clear all downloads, there is IMHO no reason to still keep it on never and it IMHO contradicts the "allow" setting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1530173938

   > There's a "gobally" -> "globally" typo you may want to take a look at before merging.
   
   thanks! I wouldn't have noticed this.
   
   
   > The only thing missing is IMHO restoring periodic updates. Given, that you now clear all downloads, there is IMHO no reason to still keep it on never and it IMHO contradicts the "allow" setting.
   
   good point. Probably better to remove the `never` option now. The usecase of `never` is also covered by the index downloads check box. Going to take a look at it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1535543955

   last test run with all tests enabled. thanks for the reviews -> going to merge today


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #4999: upgrade to maven-indexer 7.0.0

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#discussion_r1065660319


##########
java/maven.indexer/manifest.mf:
##########
@@ -3,4 +3,4 @@ OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/maven/indexer/Bundle.prop
 AutoUpdate-Show-In-Client: false
 OpenIDE-Module-Specification-Version: 2.59
 OpenIDE-Module: org.netbeans.modules.maven.indexer/2
-
+penIDE-Module-Java-Dependencies: Java > 11

Review Comment:
   fixme



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#discussion_r1179972882


##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -534,12 +532,22 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
                         httpwagon.setHttpHeaders(p);
                     }
 
-                    Path tmpStorage = Files.createTempDirectory("index-extraction");
+                    Path tmpStorage = Files.createTempDirectory(getIndexDirectory(), "extractor-");

Review Comment:
   note to self: this is extracting directly into cache right now. I am not convinced that this is a good idea since this requires the cleanup on failure/cancel/system.exit to work reliably.
   
   The advantage of this approach is that only the compressed archive will land in tmp - which should fit even into small tmp folders.



##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -637,6 +644,10 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
         }
     }
 
+    private static void pauseRemoteRepoIndexing() {
+        RepositoryPreferences.pauseIndexDownloadsFor(2, ChronoUnit.MINUTES); // pause a while  // TODO use reasonable duration

Review Comment:
   TODO: forgot to change this number



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529133180

   >  I canceled a running remote index download, then I have no option to restart that, because the "Index Now" button only triggers a local index, not an index of the remote repositories.
   
   right, canceling will add a delay before it will try to run again. This is intended. I am not sure how important the usecase is to start the indexing right after a manual cancel again. I agree that the "index now" button needs to be looked at since it is only for the local index and this is not clearly communicated in the UI. Restart after cancel is more of a dev testing issue for me and less of a common usecase.
   
   > Multithreaded indexing should IMHO be enabled by default 
   
   I don't want to do this before filtering is available since this has an index size overhead. This would be another PR. We also got feedback of notebook usage etc which I don't want to ignore either.
   
   > I suggest for the popup: 
   
   I will take a look at this. But I won't implement "run once" for now since this complicates things unnecessarily. Indexing is not a run-once feature, either you turn it on or off. Cancelling pauses it as mentioned before.
   
   > Looking at the indexing notification: Will this be a problem for LSP?
   
   likely. `IndexingNotificationProvider.java` has one method more now, if this isn't implemented and nobody sets the permission, indexing won't run now. Let me add a default implementation which simply allows all downloads to have the same behavior as before.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1 and improve index downloads

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1529116038

   @vieiro this is a list of user given permissions. Try opening a pom or something which triggers indexing, nb will then show a notification, based on what you answer it will show up in the list.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1521106752

   wip permission request notification
   ![dl-permission-bubble_v1](https://user-images.githubusercontent.com/114367/234167359-b1e6e06b-9170-4c69-8f95-473ea6329dbc.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on a diff in pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#discussion_r1179972882


##########
java/maven.indexer/src/org/netbeans/modules/maven/indexer/NexusRepositoryIndexerImpl.java:
##########
@@ -534,12 +532,22 @@ private void indexLoadedRepo(final RepositoryInfo repo, boolean updateLocal) thr
                         httpwagon.setHttpHeaders(p);
                     }
 
-                    Path tmpStorage = Files.createTempDirectory("index-extraction");
+                    Path tmpStorage = Files.createTempDirectory(getIndexDirectory(), "extractor-");

Review Comment:
   note to self: this is extracting directly into cache right now. I am not convinced that this is a good idea since this requires the cleanup on failure/cancel/system.exit to work reliably.
   
   The advantage of this approach is that only the compressed archive will land in tmp - which should fit even into the smallest tmp folders.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1446913348

   thanks to @cstamas for resolving the silo cleanup issue - works great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] mbien commented on pull request #4999: upgrade to maven-indexer 7.0.1

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4999:
URL: https://github.com/apache/netbeans/pull/4999#issuecomment-1473072009

   draft: https://github.com/apache/maven-indexer/pull/302 would give us more control over the temp storage location + give us the option to filter the index


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists