You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/11 16:36:33 UTC
[kudu-CR] [build] Fix the instance detector-test.cc license header
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15406
Change subject: [build] Fix the instance_detector-test.cc license header
......................................................................
[build] Fix the instance_detector-test.cc license header
It looks like the wrong header was used likely due to a copy from
another file. This fixes that by using the standard license header.
Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
---
M src/kudu/util/cloud/instance_detector-test.cc
1 file changed, 16 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/15406/1
--
To view, visit http://gerrit.cloudera.org:8080/15406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
Gerrit-Change-Number: 15406
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Fix the instance detector-test.cc license header
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15406 )
Change subject: [build] Fix the instance_detector-test.cc license header
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Thank you for fixing this.
http://gerrit.cloudera.org:8080/#/c/15406/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/15406/1//COMMIT_MSG@9
PS1, Line 9: likely due to a copy from
: another file
Yes, that's the case: most likely the original was src/kudu/util/cache-test.cc My bad, I copied one file over and didn't pay attention to the copyright header.
--
To view, visit http://gerrit.cloudera.org:8080/15406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
Gerrit-Change-Number: 15406
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 16:46:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] Fix the instance detector-test.cc license header
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15406 )
Change subject: [build] Fix the instance_detector-test.cc license header
......................................................................
[build] Fix the instance_detector-test.cc license header
It looks like the wrong header was used likely due to a copy from
another file. This fixes that by using the standard license header.
Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
Reviewed-on: http://gerrit.cloudera.org:8080/15406
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/cloud/instance_detector-test.cc
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
Gerrit-Change-Number: 15406
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Fix the instance detector-test.cc license header
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15406 )
Change subject: [build] Fix the instance_detector-test.cc license header
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15406
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6f9899b23dd092d349d23f74aef09dc0614fdd67
Gerrit-Change-Number: 15406
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 11 Mar 2020 16:39:48 +0000
Gerrit-HasComments: No