You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Mryange (via GitHub)" <gi...@apache.org> on 2026/04/08 11:45:47 UTC
[PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Mryange opened a new pull request, #62242:
URL: https://github.com/apache/doris/pull/62242
### What problem does this PR solve?
Problem Summary:
Array functions (e.g. `array_join`, `array_element`) contain repetitive boilerplate for unpacking `ColumnArray`'s Const/Nullable wrappers, extracting offsets, nested null maps, and flat data pointers. This makes the code verbose and error-prone.
This PR introduces `ColumnArrayView<PType>` — a lightweight, read-only view over `Array<scalar>` columns that automatically handles Const / Nullable unwrapping and provides a clean index-based access API via `operator[]`, returning `ArrayDataView` with `size()`, `is_null_at()`, and `value_at()` methods.
As a first adoption, `function_array_join.h` is refactored to use `ColumnArrayView<TYPE_STRING>`, removing the dependency on `extract_column_array_info` / `ColumnArrayExecutionData` and simplifying the inner loop from raw flat-index manipulation to per-row `ArrayDataView` access.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4219643671
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4205995060
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4221449033
run p0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4221456567
run external
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4213333730
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4215638953
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (76/76)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62242_2022fb5fc7345b14f09951373863fbb79394bf6a_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62242_2022fb5fc7345b14f09951373863fbb79394bf6a_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.64% (27389/37192) |
| Line Coverage | 57.27% (295537/516030) |
| Region Coverage | 54.64% (246847/451778) |
| Branch Coverage | 56.18% (106756/190035) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4206016317
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4207008820
# BE Regression && UT Coverage Report
Increment line coverage `80.26% (61/76)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62242_bbd44a684a1a679e2133bfa86bb90510bb84a3b5_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62242_bbd44a684a1a679e2133bfa86bb90510bb84a3b5_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.67% (27383/37171) |
| Line Coverage | 57.31% (295551/515685) |
| Region Coverage | 54.56% (246221/451248) |
| Branch Coverage | 56.21% (106696/189833) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4214433726
# BE Regression && UT Coverage Report
Increment line coverage `95.45% (42/44)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62242_787c700621861880c21206e01b0d86eca8a6d554_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62242_787c700621861880c21206e01b0d86eca8a6d554_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.67% (27399/37192) |
| Line Coverage | 57.27% (295539/516079) |
| Region Coverage | 54.29% (245279/451788) |
| Branch Coverage | 56.10% (106604/190041) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62242:
URL: https://github.com/apache/doris/pull/62242#discussion_r3061743575
##########
be/src/core/column/column_array_view.h:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "core/column/column_array.h"
+#include "core/column/column_execute_util.h"
+
+namespace doris {
+
+// ArrayDataView represents a read-only view of a single row's array data
+// (a slice of ColumnArray's flat nested data).
+// Used as the return type of ColumnArrayView::operator[].
+template <PrimitiveType PType>
+struct ArrayDataView {
+ using ElementType = typename ColumnElementView<PType>::ElementType;
+
+ const ColumnElementView<PType>& data;
+ const NullMap& nested_null_map;
+ const size_t offset;
+ const size_t length;
+
+ size_t size() const { return length; }
+
+ const ElementType* get_data() const {
+ const ElementType* raw_data = data.get_data();
+ return raw_data + offset;
+ }
+
+ // ColumnArray's data column is always Nullable, no need to check nullptr
+ bool is_null_at(size_t idx) const { return nested_null_map[offset + idx]; }
+
+ ElementType value_at(size_t idx) const { return data.get_element(offset + idx); }
+};
+
+// ColumnArrayView provides a read-only view over a column of Array<scalar_type>,
+// handling Const / Nullable wrapping automatically.
+//
+// Supports index-based access: operator[](row) returns ArrayDataView, uses offsets[row-1] (sentinel)
+template <PrimitiveType PType>
+struct ColumnArrayView {
+ const ColumnElementView<PType> element_data;
+ const ColumnArray::Offsets64& offsets;
+ const NullMap* outer_null_map;
+ const NullMap& nested_null_map;
+ const bool is_const;
+ const size_t count;
+
+ static ColumnArrayView create(const ColumnPtr& column_ptr) {
+ // Step 1: unpack const
+ const auto& [unpacked, is_const] = unpack_if_const(column_ptr);
+
+ // Step 2: unpack outer nullable
+ const NullMap* outer_null_map = nullptr;
+ const IColumn* array_raw = nullptr;
+ if (const auto* nullable = check_and_get_column<ColumnNullable>(unpacked.get())) {
+ outer_null_map = &nullable->get_null_map_data();
+ array_raw = nullable->get_nested_column_ptr().get();
+ } else {
+ array_raw = unpacked.get();
+ }
+
+ // Step 3: get ColumnArray
+ const auto& array_column = assert_cast<const ColumnArray&>(*array_raw);
+
+ // Step 4: unpack inner nullable (data column is always Nullable)
+ const auto& nested_nullable = assert_cast<const ColumnNullable&>(array_column.get_data());
Review Comment:
This hard-casts every array's nested storage to `ColumnNullable`, but Doris still produces plain `ColumnArray(nested->create_column(), ...)` for non-nullable `Array<T>` in `DataTypeArray::create_column()`, and the old `extract_column_array_info()` handled both shapes. That means `array_join(Array<String>)` / `l2_distance(Array<Float>, ...)` now regress on ordinary non-nullable arrays.
##########
be/src/core/column/column_array_view.h:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "core/column/column_array.h"
+#include "core/column/column_execute_util.h"
+
+namespace doris {
+
+// ArrayDataView represents a read-only view of a single row's array data
+// (a slice of ColumnArray's flat nested data).
+// Used as the return type of ColumnArrayView::operator[].
+template <PrimitiveType PType>
+struct ArrayDataView {
+ using ElementType = typename ColumnElementView<PType>::ElementType;
+
+ const ColumnElementView<PType>& data;
+ const NullMap& nested_null_map;
+ const size_t offset;
+ const size_t length;
+
+ size_t size() const { return length; }
+
+ const ElementType* get_data() const {
Review Comment:
`ColumnElementView::get_data()` returns `nullptr` when the flattened nested column is empty. This method then does pointer arithmetic on that null pointer. `FunctionArrayDistance` now calls `get_data()` for every row, so inputs like `[]` / `const([])` can hit UB here even though the previous implementation used `PaddedPODArray::data()` and stayed valid for empty arrays.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4219714169
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #62242:
URL: https://github.com/apache/doris/pull/62242#discussion_r3077682248
##########
be/src/core/column/column_array_view.h:
##########
@@ -0,0 +1,114 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#pragma once
+
+#include "core/column/column_array.h"
+#include "core/column/column_execute_util.h"
+
+namespace doris {
+
+// ArrayDataView represents a read-only view of a single row's array data
+// (a slice of ColumnArray's flat nested data).
+// Used as the return type of ColumnArrayView::operator[].
+template <PrimitiveType PType>
+struct ArrayDataView {
+ using ElementType = typename ColumnElementView<PType>::ElementType;
+
+ const ColumnElementView<PType>& data;
+ const NullMap& nested_null_map;
+ const size_t offset;
+ const size_t length;
+
+ size_t size() const { return length; }
+
+ const ElementType* get_data() const {
+ const ElementType* raw_data = data.get_data();
+ return raw_data + offset;
+ }
+
+ // ColumnArray's data column is always Nullable, no need to check nullptr
+ bool is_null_at(size_t idx) const { return nested_null_map[offset + idx]; }
+
+ ElementType value_at(size_t idx) const { return data.get_element(offset + idx); }
+};
+
+// ColumnArrayView provides a read-only view over a column of Array<scalar_type>,
+// handling Const / Nullable wrapping automatically.
+//
+// Supports index-based access: operator[](row) returns ArrayDataView, uses offsets[row-1] (sentinel)
+template <PrimitiveType PType>
+struct ColumnArrayView {
+ const ColumnElementView<PType> element_data;
+ const ColumnArray::Offsets64& offsets;
+ const NullMap* outer_null_map;
+ const NullMap& nested_null_map;
+ const bool is_const;
+ const size_t count;
+
+ static ColumnArrayView create(const ColumnPtr& column_ptr) {
+ // Step 1: unpack const
+ const auto& [unpacked, is_const] = unpack_if_const(column_ptr);
+
+ // Step 2: unpack outer nullable
+ const NullMap* outer_null_map = nullptr;
+ const IColumn* array_raw = nullptr;
+ if (const auto* nullable = check_and_get_column<ColumnNullable>(unpacked.get())) {
+ outer_null_map = &nullable->get_null_map_data();
+ array_raw = nullable->get_nested_column_ptr().get();
+ } else {
+ array_raw = unpacked.get();
+ }
+
+ // Step 3: get ColumnArray
+ const auto& array_column = assert_cast<const ColumnArray&>(*array_raw);
+
+ // Step 4: unpack inner nullable (data column is always Nullable)
+ const auto& nested_nullable = assert_cast<const ColumnNullable&>(array_column.get_data());
Review Comment:
`ColumnArray` does not guarantee that its nested payload is always `ColumnNullable`. `DataTypeArray::create_column()` still builds `ColumnArray::create(nested->create_column(), ...)`, so `Array<T NOT NULL>` reaches BE with a plain nested column, and the previous implementations handled that shape explicitly. This unconditional `assert_cast<const ColumnNullable&>` therefore regresses existing valid inputs: for example the `array_join(..._notnull)` regression cases now crash/fail as soon as they hit `ColumnArrayView::create()`. The helper needs to preserve both layouts, e.g. by checking whether `array_column.get_data()` is nullable and only wiring `nested_null_map` when it actually exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4213948673
# BE UT Coverage Report
Increment line coverage `80.00% (40/50)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/787c700621861880c21206e01b0d86eca8a6d554_787c700621861880c21206e01b0d86eca8a6d554/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/787c700621861880c21206e01b0d86eca8a6d554_787c700621861880c21206e01b0d86eca8a6d554/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.00% (20130/37978) |
| Line Coverage | 36.55% (189189/517667) |
| Region Coverage | 32.80% (146832/447662) |
| Branch Coverage | 33.91% (64250/189463) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4222109778
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (76/76)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62242_224be17f0210c1bcd3c19992b2d3989ec708318d_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62242_224be17f0210c1bcd3c19992b2d3989ec708318d_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.69% (27405/37192) |
| Line Coverage | 57.30% (295685/516030) |
| Region Coverage | 54.36% (245580/451775) |
| Branch Coverage | 56.13% (106657/190033) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4241864440
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4214627593
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4215238186
# BE UT Coverage Report
Increment line coverage `81.71% (67/82)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/2022fb5fc7345b14f09951373863fbb79394bf6a_2022fb5fc7345b14f09951373863fbb79394bf6a/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/2022fb5fc7345b14f09951373863fbb79394bf6a_2022fb5fc7345b14f09951373863fbb79394bf6a/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.00% (20130/37978) |
| Line Coverage | 36.54% (189160/517618) |
| Region Coverage | 32.82% (146900/447652) |
| Branch Coverage | 33.92% (64255/189457) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4220272516
# BE UT Coverage Report
Increment line coverage `81.71% (67/82)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/224be17f0210c1bcd3c19992b2d3989ec708318d_224be17f0210c1bcd3c19992b2d3989ec708318d/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/224be17f0210c1bcd3c19992b2d3989ec708318d_224be17f0210c1bcd3c19992b2d3989ec708318d/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.00% (20130/37978) |
| Line Coverage | 36.54% (189144/517618) |
| Region Coverage | 32.79% (146798/447649) |
| Branch Coverage | 33.91% (64249/189455) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62242:
URL: https://github.com/apache/doris/pull/62242#issuecomment-4222138677
# BE Regression && UT Coverage Report
Increment line coverage `100.00% (76/76)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62242_224be17f0210c1bcd3c19992b2d3989ec708318d_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62242_224be17f0210c1bcd3c19992b2d3989ec708318d_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 73.70% (27409/37192) |
| Line Coverage | 57.31% (295762/516030) |
| Region Coverage | 54.38% (245671/451775) |
| Branch Coverage | 56.14% (106687/190033) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [refine](column) add ColumnArrayView utility for Array column access [doris]
Posted by "Mryange (via GitHub)" <gi...@apache.org>.
Mryange closed pull request #62242: [refine](column) add ColumnArrayView utility for Array<scalar> column access
URL: https://github.com/apache/doris/pull/62242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org