You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "qijiale76 (via GitHub)" <gi...@apache.org> on 2023/07/20 11:32:43 UTC
[GitHub] [incubator-uniffle] qijiale76 opened a new pull request, #1027: [#951] fix: rss-server Docker image building bug.
qijiale76 opened a new pull request, #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
### Why are the changes needed?
(Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, describe the bug.)
Fix: #951
### Does this PR introduce _any_ user-facing change?
(Please list the user-facing changes introduced by your change, including
1. Change in user-facing APIs.
2. Addition or removal of property keys.)
No.
### How was this patch tested?
(Please test your changes, and provide instructions on how to test it:
1. If you add a feature or fix a bug, add a test to cover your changes.
2. If you fix a flaky test, repeat it for many times to prove it works.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644890058
I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #1027: [#951] fix(operator): Fix the issues of rss-server Docker image building.
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1643801773
@qijiale76 Could you correct the description of pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644904445
> > I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
>
> @zuston
>
> Hadoop version is introduced by me in #896 I think we should bind hadoop version, even if we don't use HDFS. We know mapreduce, spark and tez depend on hadoop. Because the API is changed, some version of computing framework may not be compatibility with some verison of hadoop. In production cluster, use the computing framework which is not compatibility with hadoop may produce many unexpected error.
You are right. I have checked that all the spark distribution are all bind to hadoop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1674322171
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1027?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1027](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1027?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d116cfe) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/d0f0b5725425bf453b8fac6b7aad52862730ca42?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (d0f0b57) will **increase** coverage by `0.17%`.
> Report is 41 commits behind head on master.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1027 +/- ##
============================================
+ Coverage 54.76% 54.93% +0.17%
+ Complexity 2526 2506 -20
============================================
Files 362 361 -1
Lines 19334 19298 -36
Branches 1799 1793 -6
============================================
+ Hits 10588 10602 +14
+ Misses 8116 8070 -46
+ Partials 630 626 -4
```
[see 8 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1027/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1643896486
@connorlwilkes Could you help review this pr if you have time?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zhengchenyu commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644907649
> > > I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
> >
> >
> > @zuston
> > Hadoop version is introduced by me in #896 I think we should bind hadoop version, even if we don't use HDFS. We know mapreduce, spark and tez depend on hadoop. Because the API is changed, some version of computing framework may not be compatibility with some verison of hadoop. In production cluster, use the computing framework which is not compatibility with hadoop may produce many unexpected error.
>
> You are right. I have checked that all the spark distribution are all bind to hadoop.
I just copy spark! ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zhengchenyu commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644897960
> I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
@zuston
Hadoop version is introduced by me in #896
I think we should bind hadoop version, even if we don't use HDFS. We know mapreduce, spark and tez depend on hadoop. Because the API is changed, some version of computing framework may not be compatibility with some verison of hadoop.
In production cluster, use the computing framework which is not compatibility with hadoop may produce many unexpected error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zuston commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644892595
> > I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
>
> Shuffle Server must use the HDFS jars. Because some configuration use HDFS jars.
Oh, I forgot this. This should be optimized in the later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #1027: [#951] build(operator): Add the HADOOP_VERSION for Docker image.
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1027:
URL: https://github.com/apache/incubator-uniffle/pull/1027#issuecomment-1644891410
> I'm not sure is it necessary to bind hadoop version with image. If user don't use HDFS, this is weird
Shuffle Server must use the HDFS jars. Because some configuration use HDFS jars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org