You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eumiro (via GitHub)" <gi...@apache.org> on 2023/08/17 17:34:03 UTC

[GitHub] [airflow] eumiro commented on a diff in pull request #33454: Refactor: Simplify conditions on len()

eumiro commented on code in PR #33454:
URL: https://github.com/apache/airflow/pull/33454#discussion_r1297537161


##########
scripts/ci/pre_commit/pre_commit_check_system_tests_hidden_in_index.py:
##########
@@ -79,4 +79,4 @@ def check_system_test_entry_hidden(provider_index: Path):
 if __name__ == "__main__":
     for file in sys.argv[1:]:
         check_system_test_entry_hidden(Path(file))
-    sys.exit(0 if len(errors) == 0 else 1)
+    sys.exit(1 if errors else 0)

Review Comment:
   I wouldn't use arbitrary values as exit codes: https://tldp.org/LDP/abs/html/exitcodes.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org