Re: [PR] remove unsafe use of maven dependency caching, and cache deps explicitly (druid)

["xvrl (via GitHub)" <gi...@apache.org>]

xvrl commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1414377279


##########
.github/workflows/static-checks.yml:
##########
@@ -156,7 +185,15 @@ jobs:
         with:
           distribution: 'zulu'
           java-version: '17'
-          cache: 'maven'
+
+      # restore maven dependencies only. 'depsonly' keys are safe to restore
+      # since they don't contain any artifacts created by mvn install
+      - uses: actions/cache@v3

Review Comment:
   it does run maven as part of `${MVN} test -pl 'web-console'`, but that might not pull most dependencies, so I'm fine switching to restore-only if we are afraid to clobber the cache with fewer dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org