You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/01/23 10:53:24 UTC
[GitHub] [skywalking] kezhenxu94 commented on pull request #10302: Support reload certs in HTTPS server.
kezhenxu94 commented on PR #10302:
URL: https://github.com/apache/skywalking/pull/10302#issuecomment-1400150113
> I think usually we need a manual test. I don't think tls could be easily tested.
> Wait for @kezhenxu94
To test the reloading mechanism, we can recreate new cert pairs with scripts and update them in test and verify the API still works before and after the update, but I'm totally ok if you don't want to test this case. But we need to add a basic case that verify the https works, the same situation exists in our gRPC agent protocol server in this repo. You can take that as an example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org