You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/06/26 07:08:11 UTC
[GitHub] [incubator-seatunnel] EricJoy2048 opened a new pull request, #2062: [api-draft][Optimize] Optimize module name
EricJoy2048 opened a new pull request, #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062
<img width="996" alt="image" src="https://user-images.githubusercontent.com/32193458/175803460-ea7aafec-f834-435a-b7fa-637fd9d0e9a0.png">
Module name is too long.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168304850
> Another question, what is the module name `seatunnel-connector-seatunnel-clickhouse` will be update to? What about `connector-clickhouse` ?
how about `clickhouse-connector`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 closed pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
EricJoy2048 closed pull request #2062: [api-draft][Optimize] Optimize module name
URL: https://github.com/apache/incubator-seatunnel/pull/2062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168262496
> > How about change `seatunnel-connectors-flink`,`seatunnel-connectors-spark`,`seatunnel-connectors-seatunnel` to `flink`,`spark`,`seatunnel`? Because they are `seatunnel-connectors`'s sub module. @ruanwenjun @CalvinKirs
>
> How about we separate out the `seatunnel-connector`? In our later planning, it seems that the separate connector support of `flink` or `spark` will be gradually abandoned.
Do you mean we move flink-connector, spark-connector, seatunnel-connector to the first level module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1166760654
How about change `seatunnel-connectors-flink`,`seatunnel-connectors-spark`,`seatunnel-connectors-seatunnel` to `flink`,`spark`,`seatunnel`? Because they are `seatunnel-connectors`'s sub module. @ruanwenjun @CalvinKirs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1166778101
> How about change `seatunnel-connectors-flink`,`seatunnel-connectors-spark`,`seatunnel-connectors-seatunnel` to `flink`,`spark`,`seatunnel`? Because they are `seatunnel-connectors`'s sub module. @ruanwenjun @CalvinKirs
How about we separate out the `seatunnel-connector`? In our later planning, it seems that the separate connector support of `flink` or `spark` will be gradually abandoned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168278494
> > Are we only changing `seatunnel-connector` to the first level module?
>
> Just split the new connector into a first-level module. (because it has nothing to do with the engine)
Ok, what's the name of the first-level module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168313901
> > Another question, what is the module name `seatunnel-connector-seatunnel-clickhouse` will be update to? What about `connector-clickhouse` ?
>
> how about `clickhouse-connector`?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168395988
link https://github.com/apache/incubator-seatunnel/issues/1946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168277221
> Are we only changing `seatunnel-connector` to the first level module?
Just split the new connector into a first-level module. (because it has nothing to do with the engine)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
ashulin commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168268765
Are we only changing `seatunnel-connector` to the first level module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2062: [api-draft][Optimize] Optimize module name
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2062:
URL: https://github.com/apache/incubator-seatunnel/pull/2062#issuecomment-1168298877
Another question, what is the module name `seatunnel-connector-seatunnel-clickhouse` will be update to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org