You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/08/23 03:33:35 UTC
[GitHub] [pulsar] shibd opened a new pull request, #17223: [fix][python client]Fix python producer build error.
shibd opened a new pull request, #17223:
URL: https://github.com/apache/pulsar/pull/17223
### Motivation
`test_producer.py` will build failed.
```
Traceback (most recent call last):
File "workspace/github/pulsar/pulsar-client-cpp/python/test_producer.py", line 35, in <module>
batching_type=BatchingType.KeyBased
NameError: name 'BatchingType' is not defined
```
### Modifications
- add import _pulsar.BatchType.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #17223: [fix][python client]Fix python producer test run failed.
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17223:
URL: https://github.com/apache/pulsar/pull/17223
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17223: [fix][python client]Fix python producer test run failed.
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17223:
URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224040182
Do we have some test coverage for python tests? It's a bit surprising that we fix such issue on master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] shibd commented on pull request #17223: [fix][python client]Fix python producer test run failed.
Posted by GitBox <gi...@apache.org>.
shibd commented on PR #17223:
URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224187933
> Do we have some test coverage for python tests? It's a bit surprising that we fix such an issue on the master branch.
This is not a unit test, it is an example code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #17223: [fix][python client]Fix python producer test run failed.
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #17223:
URL: https://github.com/apache/pulsar/pull/17223#issuecomment-1224216360
We may later move them to the `example` folder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on a diff in pull request #17223: [fix][python client]Fix python producer test run failed.
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on code in PR #17223:
URL: https://github.com/apache/pulsar/pull/17223#discussion_r952386315
##########
pulsar-client-cpp/python/test_producer.py:
##########
@@ -18,6 +18,7 @@
# under the License.
#
+from _pulsar import BatchingType
Review Comment:
```suggestion
from pulsar import BatchingType
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org