You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@servicecomb.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/05/18 06:49:00 UTC

[jira] [Commented] (SCB-593) Change log level to remind user to specify loadbalance handler

    [ https://issues.apache.org/jira/browse/SCB-593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480240#comment-16480240 ] 

ASF GitHub Bot commented on SCB-593:
------------------------------------

yhs0092 opened a new pull request #715: [SCB-593] change log level of InvokerUtils.innerSyncInvoke()
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/715
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   See details in [SCB-593](https://issues.apache.org/jira/browse/SCB-593)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Change log level to remind user to specify loadbalance handler
> --------------------------------------------------------------
>
>                 Key: SCB-593
>                 URL: https://issues.apache.org/jira/browse/SCB-593
>             Project: Apache ServiceComb
>          Issue Type: Bug
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m2
>            Reporter: YaoHaishi
>            Assignee: YaoHaishi
>            Priority: Major
>
> The loadbalance handler must be configured in consumer handler chain to choose provider instance.
> But currently if users overwrite the handler chain configuration and forget to configure loadbalance handler (like below), the consumer may only print exception message in InvokerUtils.innerSyncInvoke() in DEBUG level. This is easy to be ignored and make the problem confusing.
> {code:java}
> servicecomb:
>   handler:
>     chain:
>       Consumer:
>         default: qps-flowcontrol-consumer
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)