You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2020/11/19 21:34:00 UTC
[incubator-superset] branch hugh/SO-1117-modal updated: linting
This is an automated email from the ASF dual-hosted git repository.
hugh pushed a commit to branch hugh/SO-1117-modal
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git
The following commit(s) were added to refs/heads/hugh/SO-1117-modal by this push:
new 07e7388 linting
07e7388 is described below
commit 07e7388487c53fb03e7b63112f96092bc3d0c711
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu Nov 19 13:33:24 2020 -0800
linting
---
superset-frontend/src/SqlLab/components/ResultSet.tsx | 12 ++----------
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/superset-frontend/src/SqlLab/components/ResultSet.tsx b/superset-frontend/src/SqlLab/components/ResultSet.tsx
index 02f0bd7..7121107 100644
--- a/superset-frontend/src/SqlLab/components/ResultSet.tsx
+++ b/superset-frontend/src/SqlLab/components/ResultSet.tsx
@@ -199,12 +199,8 @@ export default class ResultSet extends React.PureComponent<
}
handleOverwriteDataset() {
- console.log('handle overwrite dataset')
const { sql, results } = this.props.query;
const { datasetToOverwrite } = this.state
- console.log(sql)
- console.log(results.selected_columns)
- console.log(datasetToOverwrite)
// HACK: to clear the columns in the previous dataset and update
// it with the new selected columns from the query
@@ -231,16 +227,12 @@ export default class ResultSet extends React.PureComponent<
}
handleSaveInDataset() {
- console.log('Saving dataset');
- console.log(this.state.saveDatasetRadioBtnState)
+ // if user wants to overwrite a dataset we need to prompt them
if (this.state.saveDatasetRadioBtnState === 2) {
this.setState({overwriteDataSet: true})
- console.log('make sure user is okay with overwriting')
return
}
- console.log(this.props.query);
- console.log(this.props.actions.createDatasource);
const { schema, sql, dbId, templateParams } = this.props.query;
let selectedColumns;
@@ -284,7 +276,7 @@ export default class ResultSet extends React.PureComponent<
}
handleHideSaveModal() {
- this.setState({showSaveDatasetModal: false})
+ this.setState({showSaveDatasetModal: false, overwriteDataSet: false})
}
handleSaveDatasetRadioBtnState(e) {