[GitHub] [kafka-site] mimaison commented on a diff in pull request #487: KAFKA-14692 Fix some errors and omissions in the migration docs

["mimaison (via GitHub)" <gi...@apache.org>]

mimaison commented on code in PR #487:
URL: https://github.com/apache/kafka-site/pull/487#discussion_r1100522020


##########
34/ops.html:
##########
@@ -3615,8 +3620,21 @@ <h3>Preparing for migration</h3>
   <h3>Provisioning the KRaft controller quorum</h3>
   <p>
     Two things are needed before the migration can begin. The brokers must be configured to support the migration and
-    a KRaft controller quorum must be deployed. For the KRaft deployment, please refer to <a href="#kraft_config">the above documentation</a>.
-    The KRaft controllers should be provisioned with the latest <code>metadata.version</code> of "3.4".
+    a KRaft controller quorum must be deployed. The KRaft controllers should be provisioned with the same cluster ID as
+    the existing Kafka cluster. This can be found by examining one of the "meta.properties" files in the data directories
+    of the brokers, or by running the following command.
+  </p>
+
+  <pre>
+    ./bin/zookeeper-shell.sh localhost:2181 get /cluster/id

Review Comment:
   Text within `<pre>` blocks keep the padding and the final line ending. I find the docs much more readable when we remove the spaces and avoid having a new line at the end.
   ```
     <pre>
   ./bin/zookeeper-shell.sh localhost:2181 get /cluster/id</pre>
   ```
   
   This applies to all other formatted blocks in this section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org