You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2023/05/29 12:43:46 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #20429: [fix][tests] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt
lhotari opened a new pull request, #20429:
URL: https://github.com/apache/pulsar/pull/20429
Fixes #20386
### Motivation
- the previous attempts #20387 and #20401 to fix the flakiness weren't effective alone
### Modifications
- add `.ignoreExceptions()` to Awaitility call
- underlying issue was IndexOutOfBoundsException which doesn't get retried by Awaitility unless `.ignoreExceptions()` has been called. The root cause was hidden by TestNG retries. There's another PR to improve this by adding some logging, #20425
- general test logic improvements
- use unique topic name
- use Closeable to close producer and consumers
- assert that the latch was triggered
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20429: [fix][test] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20429:
URL: https://github.com/apache/pulsar/pull/20429#issuecomment-1567213967
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20429?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20429](https://app.codecov.io/gh/apache/pulsar/pull/20429?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7334b4a) into [master](https://app.codecov.io/gh/apache/pulsar/commit/b5ef09e537ddb24419e9ad05b1dc940ab10ea70a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (b5ef09e) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20429?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20429 +/- ##
============================================
- Coverage 72.92% 72.87% -0.05%
+ Complexity 31897 31865 -32
============================================
Files 1865 1865
Lines 138439 138439
Branches 15192 15192
============================================
- Hits 100953 100888 -65
- Misses 29474 29537 +63
- Partials 8012 8014 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.16% <ø> (+0.01%)` | :arrow_up: |
| systests | `24.91% <ø> (+0.02%)` | :arrow_up: |
| unittests | `72.16% <ø> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 56 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20429/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #20429: [fix][test] Fix flaky test NonPersistentTopicTest.testMsgDropStat, 3rd attempt
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #20429:
URL: https://github.com/apache/pulsar/pull/20429
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org