You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alinaliBQ (via GitHub)" <gi...@apache.org> on 2025/11/03 22:28:01 UTC
[PR] GH-47713: [C++][FlightRPC] WIP: ODBC SQLMoreResults implementation [arrow]
alinaliBQ opened a new pull request, #48035:
URL: https://github.com/apache/arrow/pull/48035
### Rationale for this change
Implement SQLMoreResults for fetching more results. Arrow protocol doesn't support multiple result sets, so `no data` is returned by default in SQLMoreResults.
### What changes are included in this PR?
- SQLMoreResults & tests
### Are these changes tested?
Will be tested in CI when PR is ready for review
### Are there any user-facing changes?
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] WIP: ODBC SQLMoreResults implementation [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on code in PR #48035:
URL: https://github.com/apache/arrow/pull/48035#discussion_r2511727277
##########
cpp/src/arrow/flight/sql/odbc/tests/statement_test.cc:
##########
@@ -0,0 +1,59 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+#include "arrow/flight/sql/odbc/tests/odbc_test_suite.h"
+
+#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
+
+#include <sql.h>
+#include <sqltypes.h>
+#include <sqlucode.h>
+
+#include <limits>
+
+#include <gmock/gmock.h>
+#include <gtest/gtest.h>
+
+namespace arrow::flight::sql::odbc {
+
+template <typename T>
+class StatementTest : public T {};
+
+class StatementMockTest : public FlightSQLODBCMockTestBase {};
+class StatementRemoteTest : public FlightSQLODBCRemoteTestBase {};
+using TestTypes = ::testing::Types<StatementMockTest, StatementRemoteTest>;
+TYPED_TEST_SUITE(StatementTest, TestTypes);
Review Comment:
2 tests `TestSQLMoreResultsNoData` and `TestSQLMoreResultsInvalidFunctionSequence` are added in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48035:
URL: https://github.com/apache/arrow/pull/48035#issuecomment-3523265561
@lidavidm this draft PR is ready for review! Please have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #48035:
URL: https://github.com/apache/arrow/pull/48035#issuecomment-3682854294
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit f8e40da0aec39d8f3c2a9103bd38ee58cbf3b16e.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/58724082001) has more details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation [arrow]
Posted by "alinaliBQ (via GitHub)" <gi...@apache.org>.
alinaliBQ commented on PR #48035:
URL: https://github.com/apache/arrow/pull/48035#issuecomment-3657530224
@lidavidm Yes I can have 1 issue per PR in future. Your suggestion of using a top-level issue makes sense, just that I have tried that before and I don't think I have access since I am not a maintainer. I will mention parent issues in the child issue tickets.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #48035:
URL: https://github.com/apache/arrow/pull/48035#issuecomment-3648821978
@alinaliBQ one note for the future, do you mind making one issue per PR? It seems several of these PRs were connected to one issue, which isn't a big deal, but we generally try to have one issue per PR. Organizationally you could make a top-level issue and use GitHub's sub issues if that helps keep track of things. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-47713: [C++][FlightRPC] ODBC SQLMoreResults implementation [arrow]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #48035:
URL: https://github.com/apache/arrow/pull/48035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org