You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chris Nauroth (JIRA)" <ji...@apache.org> on 2016/10/05 18:20:21 UTC

[jira] [Updated] (HADOOP-13150) Avoid use of toString() in output of HDFS ACL shell commands.

     [ https://issues.apache.org/jira/browse/HADOOP-13150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HADOOP-13150:
-----------------------------------
    Attachment: HADOOP-13150.002.patch

I'm attaching patch 002, just fixing a few typos in JavaDocs that I spotted in the 001 patch.

[~yzhangal], [~liuml07] and [~stevel@apache.org], you had participated in the code review on HDFS-9732, which was a similar issue about transitioning to a version-stable string output in a different part of the codebase.  Are any of you interested in reviewing HADOOP-13150?

> Avoid use of toString() in output of HDFS ACL shell commands.
> -------------------------------------------------------------
>
>                 Key: HADOOP-13150
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13150
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-13150.001.patch, HADOOP-13150.002.patch
>
>
> The HDFS ACL shell commands have at least one usage of the standard Java {{toString}} method to generate shell output ({{AclEntry#toString}}).  This issue tracks conversion of that code to use methods other than {{toString}}.  The {{toString}} method is useful primarily for debugging.  It's preferrable to use a different method to ensure stable output for public interfaces, such as the shell.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org