You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/02/20 22:29:03 UTC
[GitHub] jihoonson commented on a change in pull request #7089:
ParallelIndexSubTask: support ingestSegment in delegating factories
jihoonson commented on a change in pull request #7089: ParallelIndexSubTask: support ingestSegment in delegating factories
URL: https://github.com/apache/incubator-druid/pull/7089#discussion_r258704694
##########
File path: server/src/main/java/org/apache/druid/client/coordinator/CoordinatorClient.java
##########
@@ -95,13 +97,17 @@ public Boolean isHandOffComplete(String dataSource, SegmentDescriptor descriptor
{
try {
FullResponseHolder response = druidLeaderClient.go(
- druidLeaderClient.makeRequest(HttpMethod.GET,
- StringUtils.format(
- "/druid/coordinator/v1/datasources/%s/intervals/%s/serverview?partial=%s",
- dataSource,
- interval.toString().replace('/', '_'),
- incompleteOk
- ))
+ druidLeaderClient.makeRequest(
+ HttpMethod.GET,
+ StringUtils.format(
+ "/druid/coordinator/v1/datasources/%s/intervals/%s/serverview?partial=%s",
+ // FIXME should this get url encoded while I'm at it? It was definitely needed
Review comment:
What do you mean by encoding url here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org