[GitHub] [trafficcontrol] smalenfant opened a new pull request #5221: Adding using HTTP Proxy environment variables

[GitBox <gi...@apache.org>]

smalenfant opened a new pull request #5221:
URL: https://github.com/apache/trafficcontrol/pull/5221


   ## What does this PR (Pull Request) do?
   Allowed the go-to client to use HTTP_PROXY and HTTPS_PROXY variables
   
   ## Which Traffic Control components are affected by this PR?
   
   I'm not quite sure what this all impact.
   
   - Traffic Control Client - Go
   - Traffic Monitor
   - Traffic Ops ORT
   - Traffic Portal
   - Traffic Stats
   
   ## What is the best way to verify this PR?
   
   Requires a service which doesn't have direct access to Traffic Ops but only through a proxy.
   Set the proper environment and make sure access is working afterward.
   I'm not sure if feasible to test. Seems to be more an "upstream" function of golang.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   - master (1df853c8)
   - 4.1
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org