[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5115: Feature/GEODE-7414_2_redo

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r434236188



##########
File path: geode-core/src/integrationTest/java/org/apache/geode/net/SSLSocketParameterExtensionIntegrationTest.java
##########
@@ -216,17 +217,18 @@ public void uncaughtException(final Thread thread, final Throwable throwable) {
   }
 
   public static class MySSLParameterExtension implements SSLParameterExtension {
-    DistributionConfig config;
+    Map<SSLParameterExtensionTypes, Object> config;

Review comment:
       While this addresses the compile time discovery of the value it doesn't address its typing or issues with runtime existence of the value in the map like a concrete object would. The `Map` contract on `get` says it will return `null` if the key does not exist. At runtime I must check for `null` results and respond appropriately. A non-null value must then be cast to the correct type at runtime, possibly resulting an a runtime exception. What initializes this `Map` with default values? If we address all those issue we now have a class. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org