You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by Ippezrobert <gi...@git.apache.org> on 2017/03/01 14:21:51 UTC

[GitHub] incubator-fineract pull request #299: FINERACT-412 - Add Share account in Gl...

GitHub user Ippezrobert opened a pull request:

    https://github.com/apache/incubator-fineract/pull/299

    FINERACT-412 - Add Share account in Global Search

    Commit for FINERACT-412 - Add Share account in Global Search

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Ippezrobert/incubator-fineract include_share_globalsearch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-fineract/pull/299.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #299
    
----
commit 7306bf0b89d0e434d8b20c94572834fde04c122e
Author: Ippez Robert <ip...@gmail.com>
Date:   2017-03-01T13:49:08Z

    Commit for FINERACT-412

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #299: FINERACT-412 - Add Share account in Gl...

Posted by Ippezrobert <gi...@git.apache.org>.
Github user Ippezrobert closed the pull request at:

    https://github.com/apache/incubator-fineract/pull/299


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #299: FINERACT-412 - Add Share account in Gl...

Posted by Ippezrobert <gi...@git.apache.org>.
Github user Ippezrobert commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/299#discussion_r103930777
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/search/data/SearchConditions.java ---
    @@ -43,18 +44,21 @@ public SearchConditions(final String searchQueryParam, final String searchResour
                     SEARCH_SUPPORTED_RESOURCES.LOANS.name().toLowerCase())) ? true : false;
             this.savingSeach = (null == searchResource || searchResource.toLowerCase().contains(
                     SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    +		this.shareSeach = (null == searchResource || searchResource.toLowerCase().contains(
    +                SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    --- End diff --
    
    I will fix that and send new PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-fineract pull request #299: FINERACT-412 - Add Share account in Gl...

Posted by nazeer1100126 <gi...@git.apache.org>.
Github user nazeer1100126 commented on a diff in the pull request:

    https://github.com/apache/incubator-fineract/pull/299#discussion_r103927862
  
    --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/search/data/SearchConditions.java ---
    @@ -43,18 +44,21 @@ public SearchConditions(final String searchQueryParam, final String searchResour
                     SEARCH_SUPPORTED_RESOURCES.LOANS.name().toLowerCase())) ? true : false;
             this.savingSeach = (null == searchResource || searchResource.toLowerCase().contains(
                     SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    +		this.shareSeach = (null == searchResource || searchResource.toLowerCase().contains(
    +                SEARCH_SUPPORTED_RESOURCES.SAVINGS.name().toLowerCase())) ? true : false;
    --- End diff --
    
    shareSeach should look for SEARCH_SUPPORTED_RESOURCES.SHARES not SEARCH_SUPPORTED_RESOURCES.SAVINGS


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---