You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/03/22 15:54:22 UTC

[GitHub] [maven] MartinKanters opened a new pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

MartinKanters opened a new pull request #459:
URL: https://github.com/apache/maven/pull/459


   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
    - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG-7112) filed 
          for the change (usually before you start working on it).  Trivial changes like typos do not 
          require a JIRA issue.  Your pull request should address just this issue, without 
          pulling in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`,
          where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice
          is to use the JIRA issue title in the pull request title and in the first line of the 
          commit message.
    - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will 
          be performed on your pull request automatically.
    - [x] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
    - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
    - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] MartinKanters commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

Posted by GitBox <gi...@apache.org>.
MartinKanters commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r606099395



##########
File path: maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java
##########
@@ -390,6 +400,7 @@ private Dependency toDependency( MavenProject mavenProject )
         private String resumeFrom = "";
         private String makeBehavior = "";
         private File requestedPom = new File( PARENT_MODULE, "pom.xml" );
+        private boolean isRecursive = true;

Review comment:
       Yep, I agree. It's changed now, and I've found and fixed some other inconsistencies around that parameter as well. Ready to be reviewed again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r598984435



##########
File path: maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java
##########
@@ -390,6 +400,7 @@ private Dependency toDependency( MavenProject mavenProject )
         private String resumeFrom = "";
         private String makeBehavior = "";
         private File requestedPom = new File( PARENT_MODULE, "pom.xml" );
+        private boolean isRecursive = true;

Review comment:
       Shouldn't this just be `recursive`?

##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##########
@@ -284,20 +284,7 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep
             excludedProjects.addAll( getProjectsBySelectors( request, projects, optionalSelectors, false ) );
 
             result = new ArrayList<>( projects );
-
-            for ( MavenProject excludedProject : excludedProjects )

Review comment:
       Wasn't this removed in an another commit recently?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] MartinKanters closed pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

Posted by GitBox <gi...@apache.org>.
MartinKanters closed pull request #459:
URL: https://github.com/apache/maven/pull/459


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] michael-o commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r599075153



##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##########
@@ -284,20 +284,7 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep
             excludedProjects.addAll( getProjectsBySelectors( request, projects, optionalSelectors, false ) );
 
             result = new ArrayList<>( projects );
-
-            for ( MavenProject excludedProject : excludedProjects )

Review comment:
       OK, makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] mthmulders commented on a change in pull request #459: [MNG-7112] --projects flag should honor --non-recursive flag

Posted by GitBox <gi...@apache.org>.
mthmulders commented on a change in pull request #459:
URL: https://github.com/apache/maven/pull/459#discussion_r599048155



##########
File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##########
@@ -284,20 +284,7 @@ public DefaultGraphBuilder( BuildResumptionDataRepository buildResumptionDataRep
             excludedProjects.addAll( getProjectsBySelectors( request, projects, optionalSelectors, false ) );
 
             result = new ArrayList<>( projects );
-
-            for ( MavenProject excludedProject : excludedProjects )

Review comment:
       I think you mean [this one](https://github.com/apache/maven/pull/458)? Indeed - we'll rebase one on top of the other, depending on the order in which we merge them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org