You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/07 20:15:17 UTC

[GitHub] [activemq-artemis] jbertram commented on a change in pull request #3614: ARTEMIS-3329 ability to purge all queues on address

jbertram commented on a change in pull request #3614:
URL: https://github.com/apache/activemq-artemis/pull/3614#discussion_r646908986



##########
File path: artemis-commons/src/main/java/org/apache/activemq/artemis/logs/AuditLogger.java
##########
@@ -2833,4 +2833,30 @@ static void isAutoCreated(Object source) {
    @LogMessage(level = Logger.Level.INFO)
    @Message(id = 601747, value = "User {0} is getting auto-created property on target resource: {1} {2}", format = Message.Format.MESSAGE_FORMAT)
    void isAutoCreated(String user, Object source, Object... args);
+
+   static void purge(Object source) {
+      LOGGER.purge(getCaller(), source);
+   }
+
+   @LogMessage(level = Logger.Level.INFO)
+   @Message(id = 601748, value = "User {0} is purging target resource: {1} {2}", format = Message.Format.MESSAGE_FORMAT)
+   void purge(String user, Object source, Object... args);
+
+
+   static void purgeAddressSuccess(String queueName) {
+      RESOURCE_LOGGER.purgeAddressSuccess(getCaller(), queueName);
+   }
+
+   @LogMessage(level = Logger.Level.INFO)
+   @Message(id = 601749, value = "User {0} has purged address {1}", format = Message.Format.MESSAGE_FORMAT)
+   void purgeAddressSuccess(String user, String queueName);
+
+
+   static void purgeAddressFailure(String queueName) {
+      RESOURCE_LOGGER.purgeAddressFailure(getCaller(), queueName);
+   }
+
+   @LogMessage(level = Logger.Level.INFO)

Review comment:
       I'm not sure that's appropriate for the audit log. There are *lots* of places where failures are logged in the audit log and there are no debugging details. This is just following that same pattern (e.g. from `pause`, `resume`, etc.).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org