You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "nikam14 (via GitHub)" <gi...@apache.org> on 2023/02/27 10:01:01 UTC
[GitHub] [incubator-eventmesh] nikam14 opened a new pull request, #3281: [#3255] removed Synchronization
nikam14 opened a new pull request, #3281:
URL: https://github.com/apache/incubator-eventmesh/pull/3281
made changes mentioned in issue #3255 .
open for help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] nikam14 commented on a diff in pull request #3281: [#3255] removed Synchronization
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 commented on code in PR #3281:
URL: https://github.com/apache/incubator-eventmesh/pull/3281#discussion_r1119762957
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/SubStreamHandler.java:
##########
@@ -159,19 +159,15 @@ public void close() {
private void senderOnNext(final Subscription subscription) {
Review Comment:
Yes I am thinking same of putting back the 'synchronized' on the method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] Alonexc commented on a diff in pull request #3281: [#3255] removed Synchronization
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on code in PR #3281:
URL: https://github.com/apache/incubator-eventmesh/pull/3281#discussion_r1119502256
##########
eventmesh-sdk-java/src/main/java/org/apache/eventmesh/client/grpc/consumer/SubStreamHandler.java:
##########
@@ -159,19 +159,15 @@ public void close() {
private void senderOnNext(final Subscription subscription) {
Review Comment:
My suggestion is to put 'synchronized' on the method. Do you have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] nikam14 closed pull request #3281: [#3255] removed Synchronization
Posted by "nikam14 (via GitHub)" <gi...@apache.org>.
nikam14 closed pull request #3281: [#3255] removed Synchronization
URL: https://github.com/apache/incubator-eventmesh/pull/3281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org