You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@activemq.apache.org by Skiler <gi...@git.apache.org> on 2017/12/13 10:33:56 UTC

[GitHub] activemq-artemis pull request #1706: ARTEMIS-1555 MQTT - Unsubscribe topic i...

GitHub user Skiler opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1706

    ARTEMIS-1555 MQTT - Unsubscribe topic in cluster environment leaves ...

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Skiler/activemq-artemis remoteQueueSubscription

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1706
    
----
commit 0be0d4592da3408d20ce953865b9afe27fc575a3
Author: raul.valdoleiros <ra...@ceiia.com>
Date:   2017-12-13T10:31:34Z

    ARTEMIS-1555 MQTT - Unsubscribe topic in cluster environment leaves ...

----


---

[GitHub] activemq-artemis pull request #1706: ARTEMIS-1555 MQTT - Unsubscribe topic i...

Posted by Skiler <gi...@git.apache.org>.

Github user Skiler closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/1706


---

[GitHub] activemq-artemis issue #1706: ARTEMIS-1555 MQTT - Unsubscribe topic in clust...

Posted by Skiler <gi...@git.apache.org>.

Github user Skiler commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1706
  
    The actual XSD test is outdated, it doesn't support "default-address-routing-type" for instance. I thought it was a good ideia to update it. I will revert it.


---

[GitHub] activemq-artemis issue #1706: ARTEMIS-1555 MQTT - Unsubscribe topic in clust...

Posted by jbertram <gi...@git.apache.org>.

Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1706
  
    Couple of things...
    
    - Brokers used in tests should be configured programmatically rather than using file-based XML config.
    - There are lots of XSD changes which seem unrelated to the commit
    - The commit message is incomplete.


---

[GitHub] activemq-artemis issue #1706: ARTEMIS-1555 MQTT - Unsubscribe topic in clust...

Posted by Skiler <gi...@git.apache.org>.

Github user Skiler commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1706
  
    Fixed by https://github.com/apache/activemq-artemis/pull/1718


---