You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/12/23 17:52:28 UTC
[PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
szetszwo opened a new pull request, #5860:
URL: https://github.com/apache/ozone/pull/5860
## What changes were proposed in this pull request?
```java
//OzoneManagerRequestHandler
public OMClientResponse handleWriteRequest(OMRequest omRequest,
long transactionLogIndex) throws IOException {
```
In OzoneManagerRequestHandler.handleWriteRequest, only transactionLogIndex is passed without the term. However, it uses a Map/Function to get the term later on. We should pass TransactionInfo, which includes both term and index.
```java
//OzoneManagerDoubleBuffer
Function<Long, Long> indexToTerm
```
## What is the link to the Apache JIRA
HDDS-10006
## How was this patch tested?
Updating existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #5860:
URL: https://github.com/apache/ozone/pull/5860
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5860:
URL: https://github.com/apache/ozone/pull/5860#issuecomment-1870162700
> ... which is not needed in applyTransaction case.
@ChenSammi , thanks for reviewing this! `TransactionInfo` is needed for [omMetadataManager.getTransactionInfoTable().putWithBatch(..)](https://github.com/apache/ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java#L374-L375).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5860:
URL: https://github.com/apache/ozone/pull/5860#issuecomment-1870963197
@ChenSammi , thanks a lots for reviewing and merging this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #5860:
URL: https://github.com/apache/ozone/pull/5860#issuecomment-1870007180
@szetszwo , thanks working on this, the idea is very straight forward. But from performance and GC point of view, the TransactionInfo.value() construction in applyTransaction is expensive compared with current solution. In TransactionInfo.value(), it will construct a transactionInfoString every time which is not needed in applyTransaction case.
Instead of pass in TransactionInfo, pass TermIndex is enough and not that expensive than TransactionInfo. Or keeping the current solution is also an option to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-10006. Pass TransactionInfo in OzoneManagerRequestHandler.handleWriteRequest. [ozone]
Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on PR #5860:
URL: https://github.com/apache/ozone/pull/5860#issuecomment-1870213355
> Instead of pass in TransactionInfo, we can pass TermIndex which is enough and not that expensive than TransactionInfo.
@ChenSammi , Tried to use TermIndex instead of TransactionInfo (https://github.com/apache/ozone/pull/5860/commits/4bfd86b1a0bcaaf47e62b45645761d99380a68db). It is good idea. Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org