You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/01 03:42:34 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #35376: [SPARK-38081][K8S][TESTS] Support cloud-backend in K8s IT with SBT
dongjoon-hyun opened a new pull request #35376:
URL: https://github.com/apache/spark/pull/35376
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35376:
URL: https://github.com/apache/spark/pull/35376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35376:
URL: https://github.com/apache/spark/pull/35376#issuecomment-1027035109
Yes, there are several improvements in SBT area. Since it's broad, let me make a separate doc PR for that, @viirya .
> The document integration-tests/README.md seems not mention how to run K8S IT using sbt. Should we update it too?
```
(This PR) [SPARK-38081][K8S][TESTS] Support cloud-backend in K8s IT with SBT
419d17378c [SPARK-38072][K8S][TESTS] Support K8s imageTag parameter in SBT K8s IT
71c34b42f3 [SPARK-38071][K8S][TESTS] Support K8s namespace parameter in SBT K8s IT
ed3ea989f9 [SPARK-37713][K8S][FOLLOWUP] Fix insufficient namespace propagation
169be3e1e6 [SPARK-38049][K8S][TESTS] Use Java 17 in K8s integration tests by default
4f75577234 [SPARK-38048][K8S][TESTS] Add `IntegrationTestBackend.describePods` to support all K8s test backends
69c213d356 [SPARK-38029][K8S][TESTS] Support K8S integration test in SBT
```
Merged to master~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35376:
URL: https://github.com/apache/spark/pull/35376#discussion_r796812984
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -187,7 +187,7 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<tr>
<td><code>spark.kubernetes.test.master</code></td>
<td>
- When using the <code>cloud-url</code> backend must be specified to indicate the K8S master URL to communicate
Review comment:
Okay, got it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35376: [SPARK-38081][K8S][TESTS] Support running `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35376:
URL: https://github.com/apache/spark/pull/35376#issuecomment-1026450882
cc @williamhyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35376:
URL: https://github.com/apache/spark/pull/35376#issuecomment-1026553562
Could you review this PR, @viirya ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35376:
URL: https://github.com/apache/spark/pull/35376#discussion_r796774769
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -187,7 +187,7 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<tr>
<td><code>spark.kubernetes.test.master</code></td>
<td>
- When using the <code>cloud-url</code> backend must be specified to indicate the K8S master URL to communicate
Review comment:
No~ This was a typo. We have only `cloud` backend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35376:
URL: https://github.com/apache/spark/pull/35376#discussion_r796361752
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -187,7 +187,7 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<tr>
<td><code>spark.kubernetes.test.master</code></td>
<td>
- When using the <code>cloud-url</code> backend must be specified to indicate the K8S master URL to communicate
Review comment:
Is there a `cloud-url` backend before? This document only lists `minikube`, `docker-for-desktop`, `cloud` as available backends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #35376:
URL: https://github.com/apache/spark/pull/35376#discussion_r796361752
##########
File path: resource-managers/kubernetes/integration-tests/README.md
##########
@@ -187,7 +187,7 @@ to the wrapper scripts and using the wrapper scripts will simply set these appro
<tr>
<td><code>spark.kubernetes.test.master</code></td>
<td>
- When using the <code>cloud-url</code> backend must be specified to indicate the K8S master URL to communicate
Review comment:
Is there a `cloud-url` backend before?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35376: [SPARK-38081][K8S][TESTS] Support `cloud`-backend in K8s IT with SBT
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35376:
URL: https://github.com/apache/spark/pull/35376#issuecomment-1057478328
I backported this test-only patch to branch-3.2 for Apache Spark 3.2.2. This is verified with `EKS Graviton (ARM64)` cluster directly on the latest `branch-3.2` + this patch.
```
$ build/sbt -Psparkr -Pkubernetes -Pkubernetes-integration-tests -Dtest.exclude.tags=minikube,local -Dspark.kubernetes.test.deployMode=cloud -Dspark.kubernetes.test.master=k8s://https://....eks.amazonaws.com -Dspark.kubernetes.test.imageRepo=... -Dspark.kubernetes.test.imageTag=20220302 "kubernetes-integration-tests/test"
...
[info] KubernetesSuite:
[info] - Run SparkPi with no resources (55 seconds, 72 milliseconds)
[info] - Run SparkPi with a very long application name. (14 seconds, 66 milliseconds)
[info] - Use SparkLauncher.NO_RESOURCE (13 seconds, 491 milliseconds)
[info] - Run SparkPi with a master URL without a scheme. (13 seconds, 515 milliseconds)
[info] - Run SparkPi with an argument. (13 seconds, 599 milliseconds)
[info] - Run SparkPi with custom labels, annotations, and environment variables. (13 seconds, 895 milliseconds)
[info] - All pods have the same service account by default (14 seconds, 12 milliseconds)
[info] - Run extraJVMOptions check on driver (7 seconds, 538 milliseconds)
[info] - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties (15 seconds, 350 milliseconds)
[info] - Run SparkPi with env and mount secrets. (23 seconds, 595 milliseconds)
[info] - Run PySpark on simple pi.py example (33 seconds, 942 milliseconds)
[info] - Run PySpark to test a pyfiles example (18 seconds, 532 milliseconds)
[info] - Run PySpark with memory customization (15 seconds, 747 milliseconds)
[info] - Run in client mode. (10 seconds, 351 milliseconds)
[info] - Start pod creation from template (13 seconds, 869 milliseconds)
[info] - Test basic decommissioning (47 seconds, 300 milliseconds)
[info] - Test basic decommissioning with shuffle cleanup (48 seconds, 170 milliseconds)
[info] - Test decommissioning with dynamic allocation & shuffle cleanups (2 minutes, 49 seconds)
[info] - Test decommissioning timeouts (47 seconds, 304 milliseconds)
[info] - Run SparkR on simple dataframe.R example (54 seconds, 275 milliseconds)
[info] Run completed in 13 minutes, 29 seconds.
[info] Total number of tests run: 20
[info] Suites: completed 1, aborted 0
[info] Tests: succeeded 20, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.
[success] Total time: 1059 s (17:39), completed Mar 2, 2022, 3:01:10 PM
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org