You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/08/20 11:56:27 UTC
Review Request 68429: Fixed paths to 3rdparty test executable under
Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68429/
-----------------------------------------------------------
Review request for mesos and Andrew Schwartzmeyer.
Repository: mesos
Description
-------
Fixed paths to 3rdparty test executable under Windows.
Diffs
-----
support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e
Diff: https://reviews.apache.org/r/68429/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 68429: Fixed paths to 3rdparty test executable
under Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
> On Aug. 20, 2018, 5:54 a.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> >
> > Reviews applied: `['68318', '68319', '68429']`
> >
> > Failed command: `Start-MesosCITesting`
> >
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429
> >
> > Relevant logs:
> >
> > - [stout-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429/logs/stout-tests.log):
> >
> > ```
> > 'D:\DCOS\mesos\3rdparty\stout\tests\Debug\stout-tests.exe' is not recognized as an internal or external command,
> > operable program or batch file.
> > ```
> >
> > - [libprocess-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429/logs/libprocess-tests.log):
> >
> > ```
> > 'D:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe' is not recognized as an internal or external command,
> > operable program or batch file.
> > ```
If you want to fix this: https://github.com/Microsoft/mesos-jenkins/blob/master/Mesos/start-windows-build.ps1
Also, I don't think editted file is still in use... except maybe by an ASF machine? Ping Joseph. We tried to delete it and something stopped us. https://reviews.apache.org/r/65441/
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68429/#review207612
-----------------------------------------------------------
On Aug. 20, 2018, 4:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68429/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 4:56 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed paths to 3rdparty test executable under Windows.
>
>
> Diffs
> -----
>
> support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e
>
>
> Diff: https://reviews.apache.org/r/68429/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68429: Fixed paths to 3rdparty test executable
under Windows.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68429/#review207612
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68318', '68319', '68429']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429
Relevant logs:
- [stout-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429/logs/stout-tests.log):
```
'D:\DCOS\mesos\3rdparty\stout\tests\Debug\stout-tests.exe' is not recognized as an internal or external command,
operable program or batch file.
```
- [libprocess-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2196/mesos-review-68429/logs/libprocess-tests.log):
```
'D:\DCOS\mesos\3rdparty\libprocess\src\tests\Debug\libprocess-tests.exe' is not recognized as an internal or external command,
operable program or batch file.
```
- Mesos Reviewbot Windows
On Aug. 20, 2018, 11:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68429/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 11:56 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed paths to 3rdparty test executable under Windows.
>
>
> Diffs
> -----
>
> support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e
>
>
> Diff: https://reviews.apache.org/r/68429/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68429: Fixed paths to 3rdparty test executable
under Windows.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68429/#review207620
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68318, 68319, 68429]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 20, 2018, 11:56 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68429/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 11:56 a.m.)
>
>
> Review request for mesos and Andrew Schwartzmeyer.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed paths to 3rdparty test executable under Windows.
>
>
> Diffs
> -----
>
> support/windows-build.bat 49732c4baae3bdcdf8254ded03e7dab961b74b2e
>
>
> Diff: https://reviews.apache.org/r/68429/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>