[GitHub] [dubbo] changfubai commented on a change in pull request #8609: Optimize some code of the cluster module

[GitBox <gi...@apache.org>]

changfubai commented on a change in pull request #8609:
URL: https://github.com/apache/dubbo/pull/8609#discussion_r697313119



##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/RouterChain.java
##########
@@ -207,10 +207,10 @@ public void setInvokers(List<Invoker<T>> invokers) {
 
     /**
      * Build the asynchronous address cache for stateRouter.
-     * @param notify Whether the addresses in registry has changed.
+     * @param notify Whether the addresses in registry have changed.

Review comment:
       `has` is not right? (;´・`)>

##########
File path: dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/router/tag/TagDynamicStateRouter.java
##########
@@ -121,7 +121,7 @@ public boolean isRuntime() {
 
     @Override
     public boolean isEnable() {
-        return true;
+        return tagRouterRule.isEnabled();

Review comment:
       check tagRouterRule not null.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org